From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: David Laight <David.Laight@ACULAB.COM>,
"'ye.xingchen@zte.com.cn'" <ye.xingchen@zte.com.cn>,
"3chas3@gmail.com" <3chas3@gmail.com>
Cc: "linux-atm-general@lists.sourceforge.net"
<linux-atm-general@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()
Date: Tue, 17 Jan 2023 19:42:00 +0100 [thread overview]
Message-ID: <345bf5a4-dd58-e906-0236-781ef04bd7e8@wanadoo.fr> (raw)
In-Reply-To: <913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com>
Le 17/01/2023 à 16:37, David Laight a écrit :
> From: ye.xingchen@zte.com.cn
>> Sent: 17 January 2023 09:21
>>
>> Instead of using dma_alloc_coherent() and memset() directly use
>> dma_zalloc_coherent().
>
> I'm sure I've a brain cell that remembers that dma_alloc_coherent()
> always zeros the buffer.
> So the 'zalloc' variant isn't needed and the memset() can just
> be deleted.
> OTOH is it really worth the churn.
More-over, dma_zalloc_coherent() has been removed at the very beginning
of 2019 in commit dfd32cad146e.
It is not existing since v5.0-rc2.
\o/
CJ
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-01-17 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:21 [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent() ye.xingchen
2023-01-17 15:37 ` David Laight
2023-01-17 18:42 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345bf5a4-dd58-e906-0236-781ef04bd7e8@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=3chas3@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox