From: David Laight <David.Laight@ACULAB.COM>
To: "'ye.xingchen@zte.com.cn'" <ye.xingchen@zte.com.cn>,
"3chas3@gmail.com" <3chas3@gmail.com>
Cc: "linux-atm-general@lists.sourceforge.net"
<linux-atm-general@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()
Date: Tue, 17 Jan 2023 15:37:43 +0000 [thread overview]
Message-ID: <913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com> (raw)
In-Reply-To: <202301171721076625091@zte.com.cn>
From: ye.xingchen@zte.com.cn
> Sent: 17 January 2023 09:21
>
> Instead of using dma_alloc_coherent() and memset() directly use
> dma_zalloc_coherent().
I'm sure I've a brain cell that remembers that dma_alloc_coherent()
always zeros the buffer.
So the 'zalloc' variant isn't needed and the memset() can just
be deleted.
OTOH is it really worth the churn.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-01-17 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:21 [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent() ye.xingchen
2023-01-17 15:37 ` David Laight [this message]
2023-01-17 18:42 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox