* dvb-usb/technisat-usb2: Fix cut-n-paste thinko
@ 2013-09-04 23:59 Dave Jones
2013-09-05 7:28 ` Patrick Boettcher
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-09-04 23:59 UTC (permalink / raw)
To: pboettcher; +Cc: mchehab, Linux Kernel
This looks like it was cut and pasted from the code above which does similar checks on txlen,
but someone forgot to change the variable.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c b/drivers/media/usb/dvb-usb/technisat-usb2.c
index 40832a1..98d24ae 100644
--- a/drivers/media/usb/dvb-usb/technisat-usb2.c
+++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
@@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device *udev,
if (rxlen > 62) {
err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
device_addr);
- txlen = 62;
+ rxlen = 62;
}
b[0] = I2C_SPEED_100KHZ_BIT;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko
2013-09-04 23:59 dvb-usb/technisat-usb2: Fix cut-n-paste thinko Dave Jones
@ 2013-09-05 7:28 ` Patrick Boettcher
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Boettcher @ 2013-09-05 7:28 UTC (permalink / raw)
To: Dave Jones; +Cc: mchehab, Linux Kernel
Hi Dave,
On Wednesday 04 September 2013 19:59:17 Dave Jones wrote:
> This looks like it was cut and pasted from the code above which does
> similar checks on txlen, but someone forgot to change the variable.
This someone would be me.
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c
> b/drivers/media/usb/dvb-usb/technisat-usb2.c index 40832a1..98d24ae
> 100644
> --- a/drivers/media/usb/dvb-usb/technisat-usb2.c
> +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
> @@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device
> *udev, if (rxlen > 62) {
> err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
> device_addr);
> - txlen = 62;
> + rxlen = 62;
> }
>
> b[0] = I2C_SPEED_100KHZ_BIT;
Nice catch.
Mauro, feel free to add my signed-off-line, when integrating
Signed-off-by: Patrick Boettcher <pboettcher@kernellabs.com>
--
Patrick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-05 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 23:59 dvb-usb/technisat-usb2: Fix cut-n-paste thinko Dave Jones
2013-09-05 7:28 ` Patrick Boettcher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox