public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Shaomin Deng <dengshaomin@cdjrlc.com>,
	viro@zeniv.linux.org.uk, brauner@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mao Zhu <zhumao001@208suo.com>
Subject: Re: [PATCH] fs: Fix comment typo
Date: Mon, 12 Jun 2023 08:53:11 +0700	[thread overview]
Message-ID: <35a8d0f1-0def-a1f8-b3db-d48863693fbb@gmail.com> (raw)
In-Reply-To: <ZIZ31kVtPmaYBqa0@debian.me>

On 6/12/23 08:41, Bagas Sanjaya wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
>> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>>
>>> On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
>>>> From: Mao Zhu <zhumao001@208suo.com>
>>>>
>>>> Delete duplicated word in comment.
>>>
>>> On what function?
>>
>> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
>> contributors into the ground?  It appears I do.  So:
>>
>> Bagas, *stop* this.  It's a typo patch removing an extraneous word.  The
>> changelog is fine.  We absolutely do not need you playing changelog cop
>> and harassing contributors over this kind of thing.
> 
> OK, thanks for reminding me again.
> 
> At the time of reviewing, I had bad feeling that @cdjrlc.com people will
> ignore review comments (I betted due to mail setup problem that prevents
> them from properly repling to mailing lists, which is unfortunate). I
> was nitpicking because the diff context doesn't look clear to me (what
> function name?).
> 

And no wonder why several maintainers also highlight this (which prompted
me to review that way):

[1]: https://lore.kernel.org/all/162b5545-7d24-3cf2-9158-3100ef644e03@linux.intel.com/
[2]: https://lore.kernel.org/all/3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@HansenPartnership.com/

-- 
An old man doll... just what I always wanted! - Clara


  reply	other threads:[~2023-06-12  1:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-11 12:33 [PATCH] fs: Fix comment typo Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya
2023-06-11 19:50   ` Jonathan Corbet
2023-06-11 20:07     ` Matthew Wilcox
2023-06-12  2:00       ` Bagas Sanjaya
2023-06-12  1:41     ` Bagas Sanjaya
2023-06-12  1:53       ` Bagas Sanjaya [this message]
2023-06-12  6:34     ` Christian Brauner
2023-06-12  8:34       ` Christian Brauner
2023-06-12  9:18         ` Bagas Sanjaya
2023-06-12  6:31 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35a8d0f1-0def-a1f8-b3db-d48863693fbb@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dengshaomin@cdjrlc.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zhumao001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox