public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Shaomin Deng <dengshaomin@cdjrlc.com>,
	viro@zeniv.linux.org.uk, brauner@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mao Zhu <zhumao001@208suo.com>
Subject: Re: [PATCH] fs: Fix comment typo
Date: Sun, 11 Jun 2023 19:54:52 +0700	[thread overview]
Message-ID: <ZIXEHHvkJVlmE_c4@debian.me> (raw)
In-Reply-To: <20230611123314.5282-1-dengshaomin@cdjrlc.com>

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> From: Mao Zhu <zhumao001@208suo.com>
> 
> Delete duplicated word in comment.

On what function?

> 
> Signed-off-by: Mao Zhu <zhumao001@208suo.com>

You're carrying someone else's patch, so besides SoB from original
author, you need to also have your own SoB.

> ---
>  include/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index df6c1817906f..aa870b77cc2b 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb);
>  void dump_mapping(const struct address_space *);
>  
>  /*
> - * Userspace may rely on the the inode number being non-zero. For example, glibc
> + * Userspace may rely on the inode number being non-zero. For example, glibc
>   * simply ignores files with zero i_ino in unlink() and other places.
>   *
>   * As an additional complication, if userspace was compiled with

I don't see the function name in above diff (dump_mapping() isn't the
function I mean). Regardless, the fix LGTM.

@cdjrlc.com developers: I'm really, really fed up with you ignoring
review comments. It seems like you have issues on your mail setup. Fix
your mailer! Until then, I just say NAK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-06-11 12:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-11 12:33 [PATCH] fs: Fix comment typo Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya [this message]
2023-06-11 19:50   ` Jonathan Corbet
2023-06-11 20:07     ` Matthew Wilcox
2023-06-12  2:00       ` Bagas Sanjaya
2023-06-12  1:41     ` Bagas Sanjaya
2023-06-12  1:53       ` Bagas Sanjaya
2023-06-12  6:34     ` Christian Brauner
2023-06-12  8:34       ` Christian Brauner
2023-06-12  9:18         ` Bagas Sanjaya
2023-06-12  6:31 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIXEHHvkJVlmE_c4@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=brauner@kernel.org \
    --cc=dengshaomin@cdjrlc.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zhumao001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox