* [PATCH] arm64: dts: nuvoton: Add EDAC controller
@ 2025-04-16 0:13 William A. Kennington III
2025-04-16 6:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: William A. Kennington III @ 2025-04-16 0:13 UTC (permalink / raw)
To: Avi Fishman, Tomer Maimon, Tali Perry, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: openbmc, devicetree, linux-kernel, William A. Kennington III
We have the driver support but need a common node for all the 8xx
platforms that contain this device.
Signed-off-by: William A. Kennington III <william@wkennington.com>
---
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index 4da62308b274..ccebcb11c05e 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
#clock-cells = <1>;
};
+ mc: memory-controller@f0824000 {
+ compatible = "nuvoton,npcm845-memory-controller";
+ reg = <0x0 0xf0824000 0x0 0x2000>;
+ interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
apb {
#address-cells = <1>;
#size-cells = <1>;
--
2.49.0.604.gff1f9ca942-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller
2025-04-16 0:13 [PATCH] arm64: dts: nuvoton: Add EDAC controller William A. Kennington III
@ 2025-04-16 6:52 ` Krzysztof Kozlowski
2025-04-25 21:23 ` William Kennington
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-16 6:52 UTC (permalink / raw)
To: William A. Kennington III, Avi Fishman, Tomer Maimon, Tali Perry,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: openbmc, devicetree, linux-kernel
On 16/04/2025 02:13, William A. Kennington III wrote:
> We have the driver support but need a common node for all the 8xx
> platforms that contain this device.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---
You just sent it, so this is v2? If so, then use v2 in subject (see
other patches) and provide changelog under ---.
> arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 4da62308b274..ccebcb11c05e 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
> #clock-cells = <1>;
> };
>
> + mc: memory-controller@f0824000 {
> + compatible = "nuvoton,npcm845-memory-controller";
> + reg = <0x0 0xf0824000 0x0 0x2000>;
> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
Why is this disabled? What resources are missing?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller
2025-04-16 6:52 ` Krzysztof Kozlowski
@ 2025-04-25 21:23 ` William Kennington
2025-04-27 19:02 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: William Kennington @ 2025-04-25 21:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Avi Fishman, Tomer Maimon, Tali Perry, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, openbmc, devicetree,
linux-kernel
On Tue, Apr 15, 2025 at 11:53 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/04/2025 02:13, William A. Kennington III wrote:
> > We have the driver support but need a common node for all the 8xx
> > platforms that contain this device.
> >
> > Signed-off-by: William A. Kennington III <william@wkennington.com>
> > ---
>
> You just sent it, so this is v2? If so, then use v2 in subject (see
> other patches) and provide changelog under ---.
>
> > arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > index 4da62308b274..ccebcb11c05e 100644
> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
> > #clock-cells = <1>;
> > };
> >
> > + mc: memory-controller@f0824000 {
> > + compatible = "nuvoton,npcm845-memory-controller";
> > + reg = <0x0 0xf0824000 0x0 0x2000>;
> > + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
>
> Why is this disabled? What resources are missing?
>
I was avoiding enabling anything would not be used in the most minimal
kernel configuration (Kdump). Anyone actually using the EDAC data from
the memory controller could enable it. The np]cm7xx common dts also
has this node disabled, so it would be consistent with that SoC.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller
2025-04-25 21:23 ` William Kennington
@ 2025-04-27 19:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-27 19:02 UTC (permalink / raw)
To: William Kennington
Cc: Avi Fishman, Tomer Maimon, Tali Perry, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, openbmc, devicetree,
linux-kernel
On 25/04/2025 23:23, William Kennington wrote:
> On Tue, Apr 15, 2025 at 11:53 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 16/04/2025 02:13, William A. Kennington III wrote:
>>> We have the driver support but need a common node for all the 8xx
>>> platforms that contain this device.
>>>
>>> Signed-off-by: William A. Kennington III <william@wkennington.com>
>>> ---
>>
>> You just sent it, so this is v2? If so, then use v2 in subject (see
>> other patches) and provide changelog under ---.
>>
>>> arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> index 4da62308b274..ccebcb11c05e 100644
>>> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
>>> #clock-cells = <1>;
>>> };
>>>
>>> + mc: memory-controller@f0824000 {
>>> + compatible = "nuvoton,npcm845-memory-controller";
>>> + reg = <0x0 0xf0824000 0x0 0x2000>;
>>> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>>> + status = "disabled";
>>
>> Why is this disabled? What resources are missing?
>>
>
> I was avoiding enabling anything would not be used in the most minimal
> kernel configuration (Kdump). Anyone actually using the EDAC data from
> the memory controller could enable it. The np]cm7xx common dts also
> has this node disabled, so it would be consistent with that SoC.
DTS is nowwhere relatd to your kernel configuration, so that's wrong
assumption and wrong goals. DTSI should have disabled only devices which
need board-level resources. It seems not the case here, so drop it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: nuvoton: Add EDAC controller
@ 2025-04-15 23:34 William A. Kennington III
2025-05-07 2:52 ` Andrew Jeffery
0 siblings, 1 reply; 6+ messages in thread
From: William A. Kennington III @ 2025-04-15 23:34 UTC (permalink / raw)
To: Avi Fishman, Tomer Maimon, Tali Perry, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: openbmc, devicetree, linux-kernel, William A. Kennington III
We have the driver support but need a common node for all the 8xx
platforms that contain this device.
Signed-off-by: William A. Kennington III <william@wkennington.com>
---
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index 4da62308b274..ccebcb11c05e 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
#clock-cells = <1>;
};
+ mc: memory-controller@f0824000 {
+ compatible = "nuvoton,npcm845-memory-controller";
+ reg = <0x0 0xf0824000 0x0 0x2000>;
+ interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
apb {
#address-cells = <1>;
#size-cells = <1>;
--
2.49.0.604.gff1f9ca942-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller
2025-04-15 23:34 William A. Kennington III
@ 2025-05-07 2:52 ` Andrew Jeffery
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2025-05-07 2:52 UTC (permalink / raw)
To: William A. Kennington III, Avi Fishman, Tomer Maimon, Tali Perry,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: devicetree, openbmc, linux-kernel
On Tue, 2025-04-15 at 16:34 -0700, William A. Kennington III wrote:
> We have the driver support but need a common node for all the 8xx
> platforms that contain this device.
>
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---
> arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 4da62308b274..ccebcb11c05e 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
> #clock-cells = <1>;
> };
>
> + mc: memory-controller@f0824000 {
> + compatible = "nuvoton,npcm845-memory-controller";
> + reg = <0x0 0xf0824000 0x0 0x2000>;
> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
The patch fails to apply due to fuzz, do you mind rebasing it on
nuvoton/arm64/dt from [1]?
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/arj/bmc.git
Possibly it's the result of applying other patches of yours as they
were sent independently. It might be best to send them as a series even
if they are conceptually independent.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-07 2:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 0:13 [PATCH] arm64: dts: nuvoton: Add EDAC controller William A. Kennington III
2025-04-16 6:52 ` Krzysztof Kozlowski
2025-04-25 21:23 ` William Kennington
2025-04-27 19:02 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-04-15 23:34 William A. Kennington III
2025-05-07 2:52 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox