[PATCH v2 0/5] ARM: multi_v7_defconfig: Improve rockchip support

[PATCH v2 0/5] ARM: multi_v7_defconfig: Improve rockchip support

[Sjoerd Simons]

Enable options to provide more complete support for Rockchip boards
including: support for the common PMICs, common RTC chips, I2C, SPI,
PMW, Thermal driver, HDMI video output and USB 2.

In response to V1 there was some direct and indirect discussion about
what policy to use for deciding what to build as a module versus what to
build in. Unfortunately there doesn't seem to be any consensus in this
regard, so for this series i've stuck to the following guideline for doing
things as builtin:
* If it's needed for booting without an initramfs to an NFS root
  filesystem.
* It's needed to prevent potential damage to the SoC

This results in building in various regulators (required by the
network driver), I2C bus (to control said regulators) and the thermal
driver (to prevent thermal damage). While everything else is a module.

Fwiw, I really don't have a strong opinion myself on whether this is a
better guideline then "Built-in only the bare minimum, people can use an
initramfs to load modules as needed" which e.g. Thierry has been
advocating. However it would be nice if we could get some common
guideline from e.g. the arm-soc maintainers as the typical "module or
not" discussion that tends to happen gets rather boring rather quickly:)


Changes in v2:
- Enable all common rockchip regulators, not just ACT8846
- Only enable the USB 2 phy, not the controller as that came in through
  another tree
- Enable USB 2.0 phy as a module as the controller is a module as well
- New patch, enable common RTC drivers

Sjoerd Simons (5):
  ARM: multi_v7_defconfig: Enable common Rockchip devices/busses
  ARM: multi_v7_defconfig: Enable common regulators for rockchip boards
  ARM: multi_v7_defconfig: Enable Rockchip display support
  ARM: multi_v7_defconfig: Enable the Rockchip USB 2.0 phy
  ARM: multi_v7_defconfig: Support RTC devices commonly used on Rockchip
    boards

 arch/arm/configs/multi_v7_defconfig | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

-- 
2.5.3

[PATCH v2 1/5] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Sjoerd Simons]

Enable Rockchip I2C, SPI, PWM, thermal drivers.

Builtin are I2C (as it often required to control the pmic) and Thermal
drivers (to prevent thermal damage). SPI and PWM drivers configured as
modules

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

Changes in v2: None

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 03deb7f..170f18e 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -302,6 +302,7 @@ CONFIG_I2C_GPIO=m
 CONFIG_I2C_EXYNOS5=y
 CONFIG_I2C_MV64XXX=y
 CONFIG_I2C_RIIC=y
+CONFIG_I2C_RK3X=y
 CONFIG_I2C_S3C2410=y
 CONFIG_I2C_SH_MOBILE=y
 CONFIG_I2C_SIRF=y
@@ -318,6 +319,7 @@ CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_OMAP24XX=y
 CONFIG_SPI_ORION=y
 CONFIG_SPI_PL022=y
+CONFIG_SPI_ROCKCHIP=m
 CONFIG_SPI_RSPI=y
 CONFIG_SPI_S3C64XX=m
 CONFIG_SPI_SH_MSIOF=m
@@ -365,6 +367,7 @@ CONFIG_SENSORS_LM95245=y
 CONFIG_SENSORS_NTC_THERMISTOR=m
 CONFIG_THERMAL=y
 CONFIG_CPU_THERMAL=y
+CONFIG_ROCKCHIP_THERMAL=y
 CONFIG_RCAR_THERMAL=y
 CONFIG_ARMADA_THERMAL=y
 CONFIG_DAVINCI_WATCHDOG=m
@@ -643,6 +646,7 @@ CONFIG_PWM=y
 CONFIG_PWM_ATMEL=m
 CONFIG_PWM_ATMEL_TCB=m
 CONFIG_PWM_RENESAS_TPU=y
+CONFIG_PWM_ROCKCHIP=m
 CONFIG_PWM_SAMSUNG=m
 CONFIG_PWM_SUN4I=y
 CONFIG_PWM_TEGRA=y
-- 
2.5.3

[PATCH v2 2/5] ARM: multi_v7_defconfig: Enable common regulators for rockchip boards

[Sjoerd Simons]

Rockchip boards seem to have two common regulator setups. Various board
used the Active Semi act8846 often in combination with Silergy syr82x
regulators (e.g. Radxa Rock Pro/Rock 2, Firefly, and Netxeon R89 etc),
while others use regulator part of the Rockchip RK808 chip (e.g. the
various Veyron based chromebooks, Chipspark Popmetal etc)

Enable all these regulators.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

Changes in v2:
- Enable all common rockchip regulators, not just ACT8846

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 170f18e..3938f54 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -394,6 +394,7 @@ CONFIG_MFD_MAX14577=y
 CONFIG_MFD_MAX77686=y
 CONFIG_MFD_MAX77693=y
 CONFIG_MFD_MAX8907=y
+CONFIG_MFD_RK808=y
 CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_STMPE=y
 CONFIG_MFD_PALMAS=y
@@ -401,11 +402,14 @@ CONFIG_MFD_TPS65090=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR_AB8500=y
+CONFIG_REGULATOR_ACT8865=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_AS3722=y
 CONFIG_REGULATOR_AXP20X=y
 CONFIG_REGULATOR_BCM590XX=y
 CONFIG_REGULATOR_DA9210=y
+CONFIG_REGULATOR_FAN53555=y
+CONFIG_REGULATOR_RK808=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_MFD_SYSCON=y
 CONFIG_POWER_RESET_SYSCON=y
-- 
2.5.3

[PATCH v2 3/5] ARM: multi_v7_defconfig: Enable Rockchip display support

[Sjoerd Simons]

Enable options needed for HDMI out on rockchip: DRM driver, Rockchip
DesignWare HDMI glue and the rockchip IOMMU (dependency of the DRM
driver).

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

Changes in v2: None

 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 3938f54..660e72a 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -457,6 +457,8 @@ CONFIG_DRM_EXYNOS=m
 CONFIG_DRM_EXYNOS_DSI=y
 CONFIG_DRM_EXYNOS_FIMD=y
 CONFIG_DRM_EXYNOS_HDMI=y
+CONFIG_DRM_ROCKCHIP=m
+CONFIG_ROCKCHIP_DW_HDMI=m
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_TEGRA=y
 CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=m
@@ -634,6 +636,7 @@ CONFIG_APQ_MMCC_8084=y
 CONFIG_MSM_GCC_8660=y
 CONFIG_MSM_MMCC_8960=y
 CONFIG_MSM_MMCC_8974=y
+CONFIG_ROCKCHIP_IOMMU=y
 CONFIG_TEGRA_IOMMU_GART=y
 CONFIG_TEGRA_IOMMU_SMMU=y
 CONFIG_PM_DEVFREQ=y
-- 
2.5.3

[PATCH v2 4/5] ARM: multi_v7_defconfig: Enable the Rockchip USB 2.0 phy

[Sjoerd Simons]

Most Rockchip SoCs have a DesignWare HS OTG USB 2.0 controller, enable
the driver for the Rockchip USB 2.0 PHY to make that functional.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

Changes in v2:
- Only enable the USB 2 phy, not the controller as that came in through
  another tree
- Enable USB 2.0 phy as a module as the controller is a module as well

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 660e72a..2ce0d63 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -662,6 +662,7 @@ CONFIG_PHY_HIX5HD2_SATA=y
 CONFIG_PWM_STI=m
 CONFIG_OMAP_USB2=y
 CONFIG_TI_PIPE3=y
+CONFIG_PHY_ROCKCHIP_USB=m
 CONFIG_PHY_MIPHY28LP=y
 CONFIG_PHY_MIPHY365X=y
 CONFIG_PHY_RCAR_GEN2=m
-- 
2.5.3

[PATCH v2 5/5] ARM: multi_v7_defconfig: Support RTC devices commonly used on Rockchip boards

[Sjoerd Simons]

Similar to the power management situation on Rockchip boards, there are
two common RTC setups. For boards using the RK808 chip as a PMIC that
chip also serves as the RTC, while boards using the ACT8846 typically use
the Haoyu Microelectronics HYM8563 chip as their RTC.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

Changes in v2:
- New patch, enable common RTC drivers

 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2ce0d63..565a343 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -575,8 +575,10 @@ CONFIG_EDAC_HIGHBANK_L2=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_AS3722=y
 CONFIG_RTC_DRV_DS1307=y
+CONFIG_RTC_DRV_HYM8563=m
 CONFIG_RTC_DRV_MAX8907=y
 CONFIG_RTC_DRV_MAX77686=y
+CONFIG_RTC_DRV_RK808=m
 CONFIG_RTC_DRV_MAX77802=m
 CONFIG_RTC_DRV_RS5C372=m
 CONFIG_RTC_DRV_PALMAS=y
-- 
2.5.3

Re: [PATCH v2 2/5] ARM: multi_v7_defconfig: Enable common regulators for rockchip boards

[Heiko Stübner]

Am Donnerstag, 24. September 2015, 13:39:16 schrieb Sjoerd Simons:
> Rockchip boards seem to have two common regulator setups. Various board
> used the Active Semi act8846 often in combination with Silergy syr82x

For people just skimming over these patches, the syr82x are siblings to the 
fan53555 - same register interface and all, thus that option gets enabled.


> regulators (e.g. Radxa Rock Pro/Rock 2, Firefly, and Netxeon R89 etc),
> while others use regulator part of the Rockchip RK808 chip (e.g. the
> various Veyron based chromebooks, Chipspark Popmetal etc)
> 
> Enable all these regulators.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> 
> ---
> 
> Changes in v2:
> - Enable all common rockchip regulators, not just ACT8846
> 
>  arch/arm/configs/multi_v7_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index 170f18e..3938f54 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -394,6 +394,7 @@ CONFIG_MFD_MAX14577=y
>  CONFIG_MFD_MAX77686=y
>  CONFIG_MFD_MAX77693=y
>  CONFIG_MFD_MAX8907=y
> +CONFIG_MFD_RK808=y
>  CONFIG_MFD_SEC_CORE=y
>  CONFIG_MFD_STMPE=y
>  CONFIG_MFD_PALMAS=y
> @@ -401,11 +402,14 @@ CONFIG_MFD_TPS65090=y
>  CONFIG_MFD_TPS6586X=y
>  CONFIG_MFD_TPS65910=y
>  CONFIG_REGULATOR_AB8500=y
> +CONFIG_REGULATOR_ACT8865=y
>  CONFIG_REGULATOR_AS3711=y
>  CONFIG_REGULATOR_AS3722=y
>  CONFIG_REGULATOR_AXP20X=y
>  CONFIG_REGULATOR_BCM590XX=y
>  CONFIG_REGULATOR_DA9210=y
> +CONFIG_REGULATOR_FAN53555=y
> +CONFIG_REGULATOR_RK808=y
>  CONFIG_REGULATOR_GPIO=y
>  CONFIG_MFD_SYSCON=y
>  CONFIG_POWER_RESET_SYSCON=y

Re: [PATCH v2 0/5] ARM: multi_v7_defconfig: Improve rockchip support

[Heiko Stübner]

Am Donnerstag, 24. September 2015, 13:39:14 schrieb Sjoerd Simons:
> Enable options to provide more complete support for Rockchip boards
> including: support for the common PMICs, common RTC chips, I2C, SPI,
> PMW, Thermal driver, HDMI video output and USB 2.

As these patches are supposed to go through arm-soc directly and options 
getting enabled + the whole what gets set as built-in vs. module looks sane to 
me, I'll just provide for the whole series a:

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko

Re: [PATCH v2 0/5] ARM: multi_v7_defconfig: Improve rockchip support

[Arnd Bergmann]

On Friday 25 September 2015 00:13:29 Heiko Stübner wrote:
> Am Donnerstag, 24. September 2015, 13:39:14 schrieb Sjoerd Simons:
> > Enable options to provide more complete support for Rockchip boards
> > including: support for the common PMICs, common RTC chips, I2C, SPI,
> > PMW, Thermal driver, HDMI video output and USB 2.
> 
> As these patches are supposed to go through arm-soc directly and options 
> getting enabled + the whole what gets set as built-in vs. module looks sane to 
> me, I'll just provide for the whole series a:
> 
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Applied them all to next/defconfig

Thanks,

	Arnd