public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: kth5965@gmail.com, jaegeuk@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: chao@kernel.org, syzkaller-bugs@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: evict: truncate page cache before clear_inode
Date: Mon, 23 Mar 2026 11:14:14 +0800	[thread overview]
Message-ID: <37c11065-e055-41b8-82a8-68f2fdf56ac3@kernel.org> (raw)
In-Reply-To: <20260319151121.39737-1-kth5965@gmail.com>

On 3/19/26 23:11, kth5965@gmail.com wrote:
> Hi Chao,
> 
> Yes, I agree with your point.
> 
> I also think 2) is useful to detect the corrupted inode earlier and to
> make the issue visible through log and returned error.
> 
> But 2) alone does not seem sufficient, because we can still reach inode
> cleanup later, and then `f2fs_evict_inode()` can still go through the
> inline conversion path.
> 
> So it makes sense to me that we need both:
> 
> 1. earlier detection / guarding in sanity check
> 2. fixing the empty inline conversion path so page #0 cache is not left
>    behind
> 
> If this understanding is correct, I will prepare the fix in that
> direction.

Please go ahead w/ this, thank you!

Thanks,

> 
> Thanks.


  reply	other threads:[~2026-03-23  3:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 16:06 [PATCH] f2fs: evict: truncate page cache before clear_inode Taerang Kim
2026-02-24 16:54 ` [PATCH v2] " Taerang Kim
2026-03-09  7:44   ` Chao Yu
2026-03-09 14:25     ` [f2fs-dev] " kth5965
2026-03-13  7:45       ` Chao Yu
2026-03-17 15:28     ` kth5965
2026-03-18  3:40       ` Chao Yu
2026-03-19 15:11         ` kth5965
2026-03-23  3:14           ` Chao Yu [this message]
2026-03-31 15:24             ` kth5965

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37c11065-e055-41b8-82a8-68f2fdf56ac3@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kth5965@gmail.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox