public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Schrefl <chrisi.schrefl@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Russell King" <linux@armlinux.org.uk>,
	"Rudraksha Gupta" <guptarud@gmail.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Geert Stappers" <stappers@stappers.nl>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Jamie Cunliffe" <Jamie.Cunliffe@arm.com>,
	"Sven Van Asbroeck" <thesven73@gmail.com>,
	rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm: rust: Enable Rust support for ARMv7
Date: Sat, 5 Apr 2025 22:05:19 +0200	[thread overview]
Message-ID: <399cceb4-dcf5-4af8-a8b7-6741e9b7e8ae@gmail.com> (raw)
In-Reply-To: <CACRpkdYF0sVB2-qgy=GzETSR3+2sagVQPGdunDQDJrn8KqJorA@mail.gmail.com>

Hi Linus,

On 21.03.25 8:24 AM, Linus Walleij wrote:
> Hi Christian,
> 
> thanks for your patch!
> 
> Sorry for being late to the show. I missed this very nice patch
> that was actually on my personal TODO but I have to much
> to do and also I'm not smart with Rust, but I'm a big supporter.
> 
> On Thu, Jan 23, 2025 at 11:40 PM Christian Schrefl
> <chrisi.schrefl@gmail.com> wrote:
> 
>> +       select HAVE_RUST if CPU_LITTLE_ENDIAN && CPU_32v7
> 
> Nothing in the patch series really explains this restriction, so it
> should be in the commit message. Arnd mentions some atomics
> etc, but we really need to know exactly why this is in the patch.

This should probably work with armv6 targets, for v5 or v4 Targets a 
different target would have to be specified in the KBUILD_RUSTFLAGS.

Rust also has some big endian arm targets.

> 
> I'm a bit surprised by this since the rustc LLVM backend nowadays
> support all old ARM ISAs. I would have expected:
> 
> select HAVE_RUST if AEABI
> 
> Ideally this should work on any ARM core, but it's fair to require
> EABI.
> 
> The big reason: I think we want to be able to use Rust in kernel
> core components sooner than ARMv5 goes away from the kernel.
> 
> If testing is the only issue, I can provide testing on ARMv4, v5,
> ARMv5 BE etc, just tell me how to test. (But I guess it's more than
> that...)

The main reason that I only did this for ARMv7 was that I'm not very
familiar with older arm versions and that I only have v7 hardware for
testing.

I currently don't have much time to work on this, but when/if it 
works in qemu I'll send you a message to test it on HW.

Cheers
Christian

  reply	other threads:[~2025-04-05 20:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 22:40 [PATCH v3] arm: rust: Enable Rust support for ARMv7 Christian Schrefl
2025-01-30 23:10 ` Christian Schrefl
2025-01-31  7:40 ` Arnd Bergmann
2025-01-31 15:34   ` Christian Schrefl
2025-01-31 16:05     ` Andrew Lunn
2025-01-31 18:58       ` Christian Schrefl
2025-01-31 19:37         ` Arnd Bergmann
2025-01-31 23:42           ` Christian Schrefl
2025-02-01  0:58             ` Christian Schrefl
2025-02-02 16:57           ` Christian Schrefl
2025-02-01  0:03         ` Christian Schrefl
2025-02-05 13:12       ` Miguel Ojeda
2025-02-05 13:14         ` Alice Ryhl
2025-04-06 14:59           ` Miguel Ojeda
2025-01-31 19:18     ` Arnd Bergmann
2025-03-21  7:24 ` Linus Walleij
2025-04-05 20:05   ` Christian Schrefl [this message]
2025-04-06 14:08     ` Manish Shakya
2025-04-06 14:57       ` Miguel Ojeda
2025-04-06 21:17         ` Benno Lossin
2025-04-06 21:31           ` Miguel Ojeda
2025-04-13 21:10   ` Christian Schrefl
2025-04-13 21:31   ` Christian Schrefl
2025-04-06 21:48 ` Manish Shakya
  -- strict thread matches above, loose matches on Subject: below --
2025-04-07 16:04 Benno Lossin
2025-04-07 17:35 ` Miguel Ojeda
2025-04-07 23:03 ` Manish Shakya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=399cceb4-dcf5-4af8-a8b7-6741e9b7e8ae@gmail.com \
    --to=chrisi.schrefl@gmail.com \
    --cc=Jamie.Cunliffe@arm.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=andrew@lunn.ch \
    --cc=ardb@kernel.org \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=gary@garyguo.net \
    --cc=guptarud@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stappers@stappers.nl \
    --cc=thesven73@gmail.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox