From: Benno Lossin <benno.lossin@proton.me>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Manish Shakya <msh.shakya@gmail.com>,
chrisi.schrefl@gmail.com, Jamie.Cunliffe@arm.com,
a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, andrew@lunn.ch, ardb@kernel.org,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, corbet@lwn.net,
gary@garyguo.net, guptarud@gmail.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
stappers@stappers.nl, thesven73@gmail.com, tmgross@umich.edu
Subject: Re: [PATCH v3] arm: rust: Enable Rust support for ARMv7
Date: Mon, 07 Apr 2025 16:04:14 +0000 [thread overview]
Message-ID: <D90J8JOGEBWI.4P0BAZG2R4G7@proton.me> (raw)
On Sun Apr 6, 2025 at 11:31 PM CEST, Miguel Ojeda wrote:
> On Sun, Apr 6, 2025 at 11:17 PM Benno Lossin <benno.lossin@proton.me> wrote:
>>
>> Maybe we should rename it to something more discouraging then. Eg
>> CONFIG_RUST_BUILD_ASSERT_DISABLE.
>
> To clarify: it doesn't disable them, but rather converts them to runtime checks.
Yeah I checked what it does before. I still think that we should
consider this as disabling the build asserts.
> Perhaps it should be _ESCAPE_HATCH or _KEEP_DISABLED or _AT_RUNTIME or
> similar -- though changing it now may be even more confusing.
I don't understand what _KEEP_DISABLED would mean. For me, _DISABLE
sounds much more "threatening" than the other options.
Maybe we should also hide it behind CONFIG_EXPERT?
> The description already mentions it should not happen, and that is an
> escape hatch, and the recommendation and the default is N. So if
> someone enables it in production, they really went out of their way to
> do so, and even then they are protected by the panics (that they
> shouldn't hit at all).
I suspect that most of the people sadly don't read the description.
> Eventually, we may just want to remove it entirely if we never see a
> case failing and/or if we get proper support for those from upstream
> Rust for this.
Yeah, the upstream support would be the best. Did we ever need to enable
this option?
---
Cheers,
Benno
next reply other threads:[~2025-04-07 16:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 16:04 Benno Lossin [this message]
2025-04-07 17:35 ` [PATCH v3] arm: rust: Enable Rust support for ARMv7 Miguel Ojeda
2025-04-07 23:03 ` Manish Shakya
-- strict thread matches above, loose matches on Subject: below --
2025-01-23 22:40 Christian Schrefl
2025-01-30 23:10 ` Christian Schrefl
2025-01-31 7:40 ` Arnd Bergmann
2025-01-31 15:34 ` Christian Schrefl
2025-01-31 16:05 ` Andrew Lunn
2025-01-31 18:58 ` Christian Schrefl
2025-01-31 19:37 ` Arnd Bergmann
2025-01-31 23:42 ` Christian Schrefl
2025-02-01 0:58 ` Christian Schrefl
2025-02-02 16:57 ` Christian Schrefl
2025-02-01 0:03 ` Christian Schrefl
2025-02-05 13:12 ` Miguel Ojeda
2025-02-05 13:14 ` Alice Ryhl
2025-04-06 14:59 ` Miguel Ojeda
2025-01-31 19:18 ` Arnd Bergmann
2025-03-21 7:24 ` Linus Walleij
2025-04-05 20:05 ` Christian Schrefl
2025-04-06 14:08 ` Manish Shakya
2025-04-06 14:57 ` Miguel Ojeda
2025-04-06 21:17 ` Benno Lossin
2025-04-06 21:31 ` Miguel Ojeda
2025-04-13 21:10 ` Christian Schrefl
2025-04-13 21:31 ` Christian Schrefl
2025-04-06 21:48 ` Manish Shakya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D90J8JOGEBWI.4P0BAZG2R4G7@proton.me \
--to=benno.lossin@proton.me \
--cc=Jamie.Cunliffe@arm.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=ardb@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=corbet@lwn.net \
--cc=gary@garyguo.net \
--cc=guptarud@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=msh.shakya@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stappers@stappers.nl \
--cc=thesven73@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox