Re: Linux 2.4.2ac22

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Alan Cox wrote:

> o       Next incarnation of the i810 audio driver       (Doug Ledford)

Is this the i810 that's in Red Hat's CVS or the last copy of the big file that
I sent you?  If it's the last copy of the big file I sent you, then it has a
memory leak that needs fixed.  I committed the fix for the memory leak to the
CVS archive something like two days ago.  The patch is attached.

-- 

 Doug Ledford <dledford@redhat.com>  http://people.redhat.com/dledford
      Please check my web site for aic7xxx updates/answers before
                      e-mailing me about problems

[-- Attachment #2: linux-2.4.2-i810_audio-dealloc.patch --]
[-- Type: text/plain, Size: 454 bytes --]

--- linux/drivers/sound/i810_audio.c.save	Wed Mar 21 20:44:29 2001
+++ linux/drivers/sound/i810_audio.c	Wed Mar 21 20:44:34 2001
@@ -1820,12 +1820,11 @@
 			return -EBUSY;
 		}
 		stop_dac(state);
-		dealloc_dmabuf(state);
 	}
 	if(dmabuf->enable & ADC_RUNNING) {
 		stop_adc(state);
-		dealloc_dmabuf(state);
 	}
+	dealloc_dmabuf(state);
 	if (file->f_mode & FMODE_WRITE) {
 		state->card->free_pcm_channel(state->card, dmabuf->write_channel->num);
 	}