From: buhr@stat.wisc.edu (Kevin Buhr)
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: mojomofo@mojomofo.com (Aaron Tiensivu), linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.2ac22
Date: 23 Mar 2001 13:43:45 -0600 [thread overview]
Message-ID: <vbar8zoxocu.fsf@mozart.stat.wisc.edu> (raw)
In-Reply-To: <E14gODD-0004MR-00@the-village.bc.nu>
In-Reply-To: Alan Cox's message of "Fri, 23 Mar 2001 09:50:25 +0000 (GMT)"
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>
> > > o Fix ppp memory corruption (Kevin Buhr)
> > > | Bizzarely enough a direct re-invention of a 1.2 ppp bug
> >
> > Could this explain my MPPP skb corruption I've reported since 2.3.x?
Unless you saw this corruption immediately after a hardware-initiated
TTY hangup, my patch wouldn't have had anything to do with it.
> At most it explains some weird corruption cases with small kernel blocks.
> I really doubt they are related
And, because I screwed up, the patch doesn't have any effect on PPP
over async TTYs in 2.4.2, anyway. The compatibility code for
pre-2.4.0 versions of "pppd", which was the real source of the
problem, was removed in kernel 2.4.2, and the patch has no effect.
The compatibility code is still in the PPP-over-sync-TTY code, but
once that's removed, we can back the patch out.
There are still horrible locking problems, but they represent a
problem with the TTY line discipline switching code. It's possible
for the line discipline to be "close"d asynchronously by the "eventd"
kernel thread while other line discipline functions (even "open"!) are
sleeping. Once this is fixed, the vanilla 2.4.2 "ppp_async.c" code
(i.e., without my patch) should be lock-proof.
Kevin <buhr@stat.wisc.edu>
prev parent reply other threads:[~2001-03-23 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-22 23:55 Linux 2.4.2ac22 Alan Cox
2001-03-23 0:30 ` Doug Ledford
2001-03-23 2:54 ` Aaron Tiensivu
2001-03-23 9:50 ` Alan Cox
2001-03-23 19:43 ` Kevin Buhr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbar8zoxocu.fsf@mozart.stat.wisc.edu \
--to=buhr@stat.wisc.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mojomofo@mojomofo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox