* [PATCH] mc146818rtc.h for user land programs (2.4.10)
@ 2001-09-26 16:19 Steven Rostedt
2001-09-26 16:26 ` Alan Cox
2001-09-26 16:33 ` Ben Greear
0 siblings, 2 replies; 6+ messages in thread
From: Steven Rostedt @ 2001-09-26 16:19 UTC (permalink / raw)
To: duwe; +Cc: torvalds, Linux Kernel Mailing List
The following patch is for linux-2.4.10
This is needed for user land programs to use the
mc146818rtc.h header.
--- include/linux/mc146818rtc.h.orig Wed Sep 26 23:43:00 2001
+++ include/linux/mc146818rtc.h Wed Sep 26 23:43:25 2001
@@ -16,7 +16,9 @@
#include <linux/spinlock.h> /* spinlock_t */
#include <asm/mc146818rtc.h> /* register access macros */
+#ifdef __KERNEL__
extern spinlock_t rtc_lock; /* serialize CMOS RAM access */
+#endif
/**********************************************************************
* register summary
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mc146818rtc.h for user land programs (2.4.10)
2001-09-26 16:19 [PATCH] mc146818rtc.h for user land programs (2.4.10) Steven Rostedt
@ 2001-09-26 16:26 ` Alan Cox
2001-09-26 16:33 ` Ben Greear
1 sibling, 0 replies; 6+ messages in thread
From: Alan Cox @ 2001-09-26 16:26 UTC (permalink / raw)
To: srostedt; +Cc: duwe, torvalds, Linux Kernel Mailing List
> The following patch is for linux-2.4.10
> This is needed for user land programs to use the
> mc146818rtc.h header.
Kernel headers shouldnt be used by userland apps
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mc146818rtc.h for user land programs (2.4.10)
2001-09-26 16:19 [PATCH] mc146818rtc.h for user land programs (2.4.10) Steven Rostedt
2001-09-26 16:26 ` Alan Cox
@ 2001-09-26 16:33 ` Ben Greear
2001-09-26 17:40 ` Tim Hockin
2001-09-27 11:48 ` Torsten Duwe
1 sibling, 2 replies; 6+ messages in thread
From: Ben Greear @ 2001-09-26 16:33 UTC (permalink / raw)
To: Steven Rostedt; +Cc: duwe, Linux Kernel Mailing List
Steven Rostedt wrote:
>
> The following patch is for linux-2.4.10
> This is needed for user land programs to use the
> mc146818rtc.h header.
>
> --- include/linux/mc146818rtc.h.orig Wed Sep 26 23:43:00 2001
> +++ include/linux/mc146818rtc.h Wed Sep 26 23:43:25 2001
> @@ -16,7 +16,9 @@
> #include <linux/spinlock.h> /* spinlock_t */
> #include <asm/mc146818rtc.h> /* register access macros */
>
> +#ifdef __KERNEL__
> extern spinlock_t rtc_lock; /* serialize CMOS RAM access */
> +#endif
I can see arguing with Alan about the inclusion of linux-kernel headers
in some cases, but I don't see anything in this file that looks like a
user-space program could use. Which part of this file do the user
space programs need?
Ben
--
Ben Greear <greearb@candelatech.com> <Ben_Greear@excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mc146818rtc.h for user land programs (2.4.10)
2001-09-26 16:33 ` Ben Greear
@ 2001-09-26 17:40 ` Tim Hockin
2001-09-26 18:20 ` Steven Rostedt
2001-09-27 11:48 ` Torsten Duwe
1 sibling, 1 reply; 6+ messages in thread
From: Tim Hockin @ 2001-09-26 17:40 UTC (permalink / raw)
To: Ben Greear; +Cc: Steven Rostedt, duwe, Linux Kernel Mailing List
> in some cases, but I don't see anything in this file that looks like a
> user-space program could use. Which part of this file do the user
> space programs need?
agreed - if you need to access CMOS use rtc and nvram drivers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mc146818rtc.h for user land programs (2.4.10)
2001-09-26 17:40 ` Tim Hockin
@ 2001-09-26 18:20 ` Steven Rostedt
0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2001-09-26 18:20 UTC (permalink / raw)
To: Tim Hockin; +Cc: Ben Greear, Steven Rostedt, duwe, Linux Kernel Mailing List
On Wed, 26 Sep 2001, Tim Hockin wrote:
> > in some cases, but I don't see anything in this file that looks like a
> > user-space program could use. Which part of this file do the user
> > space programs need?
>
> agreed - if you need to access CMOS use rtc and nvram drivers.
>
Your right. I wrote some utilities using rtc, and for some reason
I had to put in mc146818rtc.h, but I see now that I don't need it.
Sorry for jumping the gun.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mc146818rtc.h for user land programs (2.4.10)
2001-09-26 16:33 ` Ben Greear
2001-09-26 17:40 ` Tim Hockin
@ 2001-09-27 11:48 ` Torsten Duwe
1 sibling, 0 replies; 6+ messages in thread
From: Torsten Duwe @ 2001-09-27 11:48 UTC (permalink / raw)
To: Ben Greear; +Cc: Steven Rostedt, Torsten.Duwe, Linux Kernel Mailing List
Ben> I can see arguing with Alan about the inclusion of linux-kernel
Ben> headers in some cases, but I don't see anything in this file that
Ben> looks like a user-space program could use. Which part of this file
Ben> do the user space programs need?
Don't want to add more spam; but since I was addressed personally I just
want to state that I agree with Ben here, as well as Tim's answer about the
fine nvram and rtc drivers.
Torsten
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-09-27 11:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-09-26 16:19 [PATCH] mc146818rtc.h for user land programs (2.4.10) Steven Rostedt
2001-09-26 16:26 ` Alan Cox
2001-09-26 16:33 ` Ben Greear
2001-09-26 17:40 ` Tim Hockin
2001-09-26 18:20 ` Steven Rostedt
2001-09-27 11:48 ` Torsten Duwe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox