[BUG]: 2.4.10 lockup using ppp on SMP

[BUG]: 2.4.10 lockup using ppp on SMP

[Till Immanuel Patzschke]

Hi,

2.4.10 (and all its 2.4.x predecessors) lock up in ppp_destroy_interface. Thanks
to the kdb I got the two tracebacks below - the all_ppp_lock interferes with
some other (socket?!) lock...
Any help is VERY much appreciated!
Thanks

Immanuel

output from kdb:

    EBP       EIP         Function(args)
           0xc02ed78a stext_lock+0x4bce
                               kernel .text.lock 0xc02e8bbc 0xc02e8bbc 0xc02f20e

0
0xf63edf3c 0xc0205698 ppp_destroy_interface+0x38 (0xf63f1800)
                               kernel .text 0xc0100000 0xc0205660 0xc0205b28
0xf63edf94 0xc02018f0 ppp_ioctl+0x2e8 (0xf6c34100, 0xf64025e0, 0x4004743c, 0x22)

                               kernel .text 0xc0100000 0xc0201608 0xc0202304
0xf63edfbc 0xc0154e39 sys_ioctl+0x239 (0x4, 0x4004743c, 0x22, 0xbffff6e4, 0x804d

f40)
                               kernel .text 0xc0100000 0xc0154c00 0xc0154ed0
           0xc01076ef system_call+0x33
                               kernel .text 0xc0100000 0xc01076bc 0xc01076f4
[0]kdb> cpu 1

Entering kdb (current=0xf61a0000, pid 525) on processor 1 due to cpu switch
[1]kdb> bt
    EBP       EIP         Function(args)
           0xc02eeae0 stext_lock+0x5f24
                               kernel .text.lock 0xc02e8bbc 0xc02e8bbc 0xc02f20e

0
0xf61a1f94 0xc0276157 sock_ioctl+0xe3 (0xf61da760, 0xf61a2da0, 0x8914, 0xbffff42

c)
                               kernel .text 0xc0100000 0xc0276074 0xc0276170
0xf61a1fbc 0xc0154e39 sys_ioctl+0x239 (0x5, 0x8914, 0xbffff42c, 0x4, 0xbffff44c)

                               kernel .text 0xc0100000 0xc0154c00 0xc0154ed0
           0xc01076ef system_call+0x33
                               kernel .text 0xc0100000 0xc01076bc 0xc01076f4


--
Till Immanuel Patzschke                 mailto: tip@internetwork-ag.de
interNetwork AG                         Phone:  +49-(0)611-1731-121
Bierstadter Str. 7                      Fax:    +49-(0)611-1731-31
D-65189 Wiesbaden                       Web:    http://www.internetwork-ag.de

Re: [BUG]: 2.4.10 lockup using ppp on SMP

[Kurt Garloff]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Fri, Sep 28, 2001 at 05:03:06PM +0200, Till Immanuel Patzschke wrote:
> Hi,
> 
> 2.4.10 (and all its 2.4.x predecessors) lock up in ppp_destroy_interface. Thanks
> to the kdb I got the two tracebacks below - the all_ppp_lock interferes with
> some other (socket?!) lock...
> Any help is VERY much appreciated!

Please try the patch that Chris Mason sent to LKML a day ago.

Regards,
-- 
Kurt Garloff  <garloff@suse.de>                          Eindhoven, NL
GPG key: See mail header, key servers         Linux kernel development
SuSE GmbH, Nuernberg, DE                                SCSI, Security

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [BUG]: 2.4.10 lockup using ppp on SMP

[Till Immanuel Patzschke]

Oops, forgot to tell - Chris Mason's patch has been applied (so NO change).
The problem seems somhow related to the general kernel lock in ioctls - to prove I
commented the unlock_kernel()/lock_kernel() in sock_ioctl out, leaving the kernel
locked during socket ioctls - bad, but proves ioctl related locking problem in
ppp_generic.c... The problem has nothing to do w/ double frees or mem. corruption
(IMO) - it seems to be related to "rest of the spin lock abuses" in ppp_generic.c...
:-)

Thanks for your help

Immanuel
Kurt Garloff wrote:

> On Fri, Sep 28, 2001 at 05:03:06PM +0200, Till Immanuel Patzschke wrote:
> > Hi,
> >
> > 2.4.10 (and all its 2.4.x predecessors) lock up in ppp_destroy_interface. Thanks
> > to the kdb I got the two tracebacks below - the all_ppp_lock interferes with
> > some other (socket?!) lock...
> > Any help is VERY much appreciated!
>
> Please try the patch that Chris Mason sent to LKML a day ago.
>
> Regards,
> --
> Kurt Garloff  <garloff@suse.de>                          Eindhoven, NL
> GPG key: See mail header, key servers         Linux kernel development
> SuSE GmbH, Nuernberg, DE                                SCSI, Security
>
>   --------------------------------------------------------------------------------
>    Part 1.2Type: application/pgp-signature

--
Till Immanuel Patzschke                 mailto: tip@internetwork-ag.de
interNetwork AG                         Phone:  +49-(0)611-1731-121
Bierstadter Str. 7                      Fax:    +49-(0)611-1731-31
D-65189 Wiesbaden                       Web:    http://www.internetwork-ag.de