Kernel 2.4.12 compile fails in ieee1284_ops.c

Kernel 2.4.12 compile fails in ieee1284_ops.c

[Colin Bayer]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

I just d/l'ed the late-night bug-fix release, and was expecting a normal 
compile, when this wrench was thrown into the works:

ieee1284_ops.c: In function `ecp_forward_to_reverse':
ieee1284_ops.c:365: `IEEE1284_PH_DIR_UNKNOWN' undeclared (first use in 
this function)
ieee1284_ops.c:365: (Each undeclared identifier is reported only once
ieee1284_ops.c:365: for each function it appears in.)
ieee1284_ops.c: In function `ecp_reverse_to_forward':
ieee1284_ops.c:397: `IEEE1284_PH_DIR_UNKNOWN' undeclared (first use in 
this function)
make[3]: *** [ieee1284_ops.o] Error 1
make[3]: Leaving directory `/usr/src/linux/drivers/parport'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux/drivers/parport'
make[1]: *** [_subdir_parport] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_dir_drivers] Error 2

Yes, I'm using RedHat (7.1), and yes, their compilers suck, but this one 
hasn't given me problems with kernel compiles in the past.  I propose 
somewhat of a one-liner patch to fix this (it's attached).

[-- Attachment #2: 1284_patch.diff --]
[-- Type: text/plain, Size: 612 bytes --]

--- linux/drivers/parport/ieee1284_ops.c	Thu Oct 11 03:42:35 2001
+++ linux-patched/drivers/parport/ieee1284_ops.c	Thu Oct 11 04:01:10 2001
@@ -362,7 +362,7 @@
 	} else {
 		DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
 			 port->name);
-		port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+		port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
 	}
 
 	return retval;
@@ -394,7 +394,7 @@
 		DPRINTK (KERN_DEBUG
 			 "%s: ECP direction: failed to switch forward\n",
 			 port->name);
-		port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+		port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
 	}