public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5  client
@ 2001-11-21 19:09 Manfred Spraul
  2001-11-21 19:23 ` more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 kuznet
  0 siblings, 1 reply; 3+ messages in thread
From: Manfred Spraul @ 2001-11-21 19:09 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: kuznet, David S. Miller, linux-kernel

 
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

> IOW:
>     Either we must demand that CPU 2 uses irq-safe spinlocks in order to 
> protect against sk->write_space(), or we must demand that CPU 1 should drop 
> 'lock1' before being allowed to call dev_kfree_skb_any().

Or dev_kfree_skb_any() should consider disabled local interrupts as
'in_irq()' and call dev_kfree_skb_irq() in this case, or the driver
could call dev_kfree_irq() if it really wants to free while holding an
irq spinlock.

But that's a known problem:
http://groups.google.com/groups?q=dev_kfree_skb_any&hl=en&rnum=1&selm=linux.net.20010905.184245.94554736.davem%40redhat.com

--
	Manfred

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5
  2001-11-21 19:09 more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 client Manfred Spraul
@ 2001-11-21 19:23 ` kuznet
  2001-11-21 20:33   ` Manfred Spraul
  0 siblings, 1 reply; 3+ messages in thread
From: kuznet @ 2001-11-21 19:23 UTC (permalink / raw)
  To: Manfred Spraul; +Cc: trond.myklebust, davem, linux-kernel

Hello!

> 				should consider disabled local interrupts as
> 'in_irq()'

How to do this?

Alexey

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5
  2001-11-21 19:23 ` more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 kuznet
@ 2001-11-21 20:33   ` Manfred Spraul
  0 siblings, 0 replies; 3+ messages in thread
From: Manfred Spraul @ 2001-11-21 20:33 UTC (permalink / raw)
  To: kuznet; +Cc: trond.myklebust, davem, linux-kernel

kuznet@ms2.inr.ac.ru wrote:
> 
> Hello!
> 
> >                               should consider disabled local interrupts as
> > 'in_irq()'
> 
> How to do this?
>
Arch specific, like __global_cli() in arch/i386/kernel/irq.c.
What about a rate-limited warning if dev_kfree_skb_any is called with
disabled interrupts?

--
	Manfred

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-11-21 20:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-11-21 19:09 more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 client Manfred Spraul
2001-11-21 19:23 ` more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 kuznet
2001-11-21 20:33   ` Manfred Spraul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox