From: Andrew Morton <akpm@zip.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: alan@lxorguk.ukuu.org.uk, matts@ksu.edu, shemminger@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: 64 bit netdev stats counter
Date: Fri, 12 Jul 2002 15:27:09 -0700 [thread overview]
Message-ID: <3D2F57BD.E9ABBBCA@zip.com.au> (raw)
In-Reply-To: 20020712.150607.35506145.davem@redhat.com
"David S. Miller" wrote:
>
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: 13 Jul 2002 00:20:53 +0100
>
> gcc will output
>
> increment low 32bit
> if zero
> increment high
>
> Which means we can rapidly get 2^32 out of sync
>
> True and this equals the "fix" suggested C code involving
> two 32-bit counters that the original author posted :-)
>
Could you make the counters per-cpu and only add them all up
in the rare case where someone wants to read the stats?
And then change all the drivers ;)
-
next prev parent reply other threads:[~2002-07-12 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1026503694.26819.4.camel@dell_ss3.pdx.osdl.net>
2002-07-12 22:02 ` 64 bit netdev stats counter Matt Stegman
2002-07-12 21:58 ` David S. Miller
2002-07-12 23:20 ` Alan Cox
2002-07-12 22:06 ` David S. Miller
2002-07-12 22:27 ` Andrew Morton [this message]
2002-07-12 22:28 ` David S. Miller
2002-07-12 22:31 ` Chris Friesen
2002-07-13 2:18 ` Alan Cox
2002-07-13 0:50 ` kuznet
2002-07-12 19:12 Matt Stegman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D2F57BD.E9ABBBCA@zip.com.au \
--to=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matts@ksu.edu \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox