* [PATCH] __devexit_p in drivers/net/tulip/de2104x.c
@ 2002-08-20 13:32 Anders Gustafsson
2002-08-20 22:10 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Anders Gustafsson @ 2002-08-20 13:32 UTC (permalink / raw)
To: linux-kernel; +Cc: trivial, torvalds
Adds __devexit_p to de_remove_one in drivers/net/tulip/de2104x.c to make it
possible to compile it with new binutils
--
//anders/g
--- a/drivers/net/tulip/de2104x.c Tue Aug 20 15:28:00 2002
+++ b/drivers/net/tulip/de2104x.c Tue Aug 20 15:28:00 2002
@@ -2136,7 +2136,7 @@
return rc;
}
-static void __exit de_remove_one (struct pci_dev *pdev)
+static void __devexit de_remove_one (struct pci_dev *pdev)
{
struct net_device *dev = pci_get_drvdata(pdev);
struct de_private *de = dev->priv;
@@ -2216,7 +2216,7 @@
.name = DRV_NAME,
.id_table = de_pci_tbl,
.probe = de_init_one,
- .remove = de_remove_one,
+ .remove = __devexit_p(de_remove_one),
#ifdef CONFIG_PM
.suspend = de_suspend,
.resume = de_resume,
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] __devexit_p in drivers/net/tulip/de2104x.c
2002-08-20 13:32 [PATCH] __devexit_p in drivers/net/tulip/de2104x.c Anders Gustafsson
@ 2002-08-20 22:10 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2002-08-20 22:10 UTC (permalink / raw)
To: Anders Gustafsson; +Cc: linux-kernel, trivial, torvalds
Anders Gustafsson wrote:
> Adds __devexit_p to de_remove_one in drivers/net/tulip/de2104x.c to make it
> possible to compile it with new binutils
Again, de_remove_one is __exit for a reason: it's not a board people
are hotplugging.
Look at the fix I made to 2.5's include/linux/init.h recently, though --
applying just the last hunk of your patch should hopefully no longer
cause a warning.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-08-20 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-20 13:32 [PATCH] __devexit_p in drivers/net/tulip/de2104x.c Anders Gustafsson
2002-08-20 22:10 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox