From: Manfred Spraul <manfred@colorfullife.com>
To: Ed Tomlinson <tomlins@cam.org>
Cc: Andrew Morton <akpm@digeo.com>,
John Levon <movement@marcelothewonderpenguin.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.5.39 kmem_cache bug
Date: Sun, 29 Sep 2002 14:13:31 +0200 [thread overview]
Message-ID: <3D96EE6B.9040605@colorfullife.com> (raw)
In-Reply-To: 200209290745.20484.tomlins@cam.org
Ed Tomlinson wrote:
>
> Yes we can do this. I would rather fix kmem_cache_destroy though. Think that, if
> we play our cards right, we can get rid of the cachep->slabs_free list with out too
> much pain.
>
Please - lets check first if the free list is actually a problem, before
deciding to kill it.
If you remove the free list, it becomes impossible to find the freeable
slab, if another (partial) slab is added to the partial list afterwards.
And I'm definitively against locking up one slab in each cache - it
coudl be a order=5 allocation. It would be possible to hack around that
(if alloc is high-order, then partial slabs do not exist), but that's
too ugly to think about.
--
Manfred
next prev parent reply other threads:[~2002-09-29 12:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-28 20:13 2.5.39 kmem_cache bug John Levon
2002-09-28 20:56 ` Andrew Morton
2002-09-28 21:12 ` Manfred Spraul
2002-09-28 21:23 ` John Levon
2002-09-28 21:35 ` Andrew Morton
2002-09-29 11:45 ` Ed Tomlinson
2002-09-29 12:13 ` Manfred Spraul [this message]
2002-09-29 13:15 ` Ed Tomlinson
2002-09-29 13:52 ` Manfred Spraul
2002-09-29 13:53 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D96EE6B.9040605@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=movement@marcelothewonderpenguin.com \
--cc=tomlins@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox