* [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match
@ 2003-09-15 22:33 Jesper Juhl
2003-09-16 9:27 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2003-09-15 22:33 UTC (permalink / raw)
To: linux-kernel
In drivers/ide/Kconfig you find the following help text for
BLK_DEV_IDE_TCQ_DEPTH
"You probably just want the default of 32 here. If you enter an invalid
number, the default value will be used."
But the default is /not/ 32, the default is 8. The patch bellow changes
the default to match the help text... An alternative is of course to
change the text to match the current default of 8, but I opted for
changing the default in this patch.
Kind regards,
Jesper Juhl <jju@dif.dk>
diff -u linux-2.6.0-test5-orig/drivers/ide/Kconfig linux-2.6.0-test5/drivers/ide/Kconfig
--- linux-2.6.0-test5-orig/drivers/ide/Kconfig 2003-09-08 21:50:03.000000000 +0200
+++ linux-2.6.0-test5/drivers/ide/Kconfig 2003-09-16 00:30:20.000000000 +0200
@@ -471,7 +471,7 @@
config BLK_DEV_IDE_TCQ_DEPTH
int "Default queue depth"
depends on BLK_DEV_IDE_TCQ
- default "8"
+ default "32"
help
Maximum size of commands to enable per-drive. Any value between 1
and 32 is valid, with 32 being the maxium that the hardware supports.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match
2003-09-15 22:33 [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match Jesper Juhl
@ 2003-09-16 9:27 ` Jens Axboe
2003-09-16 9:51 ` Ivan Gyurdiev
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2003-09-16 9:27 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel
On Tue, Sep 16 2003, Jesper Juhl wrote:
>
> In drivers/ide/Kconfig you find the following help text for
> BLK_DEV_IDE_TCQ_DEPTH
>
> "You probably just want the default of 32 here. If you enter an invalid
> number, the default value will be used."
>
> But the default is /not/ 32, the default is 8. The patch bellow changes
> the default to match the help text... An alternative is of course to
> change the text to match the current default of 8, but I opted for
> changing the default in this patch.
>
>
> Kind regards,
>
> Jesper Juhl <jju@dif.dk>
>
>
>
> diff -u linux-2.6.0-test5-orig/drivers/ide/Kconfig linux-2.6.0-test5/drivers/ide/Kconfig
> --- linux-2.6.0-test5-orig/drivers/ide/Kconfig 2003-09-08 21:50:03.000000000 +0200
> +++ linux-2.6.0-test5/drivers/ide/Kconfig 2003-09-16 00:30:20.000000000 +0200
> @@ -471,7 +471,7 @@
> config BLK_DEV_IDE_TCQ_DEPTH
> int "Default queue depth"
> depends on BLK_DEV_IDE_TCQ
> - default "8"
> + default "32"
> help
> Maximum size of commands to enable per-drive. Any value between 1
> and 32 is valid, with 32 being the maxium that the hardware supports.
Yes that is fine, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match
2003-09-16 9:27 ` Jens Axboe
@ 2003-09-16 9:51 ` Ivan Gyurdiev
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Gyurdiev @ 2003-09-16 9:51 UTC (permalink / raw)
To: Jens Axboe; +Cc: Jesper Juhl, linux-kernel
So whatever happened to this list - are those things fixed now - has any
progress been made? I've had TCQ off for ages since it's dangerous for
me. That and ACPI are the only things that don't work in 2.6 ...at least
for me.
http://www.ussg.iu.edu/hypermail/linux/kernel/0307.2/1655.html
Particulary, what happened to this one:
http://www.ussg.iu.edu/hypermail/linux/kernel/0307.3/1353.html
http://www.ussg.iu.edu/hypermail/linux/kernel/0307.3/2296.html
Perhaps it's a reiser bug ... but I do remember corrupting an xfs after
reiser, and I do remember it was 100% reproducible with depth 8 but not
32 - at 32 on boot check passes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-09-16 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-15 22:33 [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match Jesper Juhl
2003-09-16 9:27 ` Jens Axboe
2003-09-16 9:51 ` Ivan Gyurdiev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox