* cocci script from 2016 - assignment in if ?
@ 2020-06-25 2:35 joe
2020-06-25 6:49 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: joe @ 2020-06-25 2:35 UTC (permalink / raw)
To: Julia lawall; +Cc: Kris Borer, Linux Kernel
https://lore.kernel.org/patchwork/patch/649705/
Any particular reason this wasn't applied?
I ask because I added something similar recently to checkpatch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cocci script from 2016 - assignment in if ?
2020-06-25 2:35 cocci script from 2016 - assignment in if ? joe
@ 2020-06-25 6:49 ` Julia Lawall
2020-06-25 7:49 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-06-25 6:49 UTC (permalink / raw)
To: joe; +Cc: Kris Borer, Linux Kernel
On Wed, 24 Jun 2020, joe@perches.com wrote:
> https://lore.kernel.org/patchwork/patch/649705/
>
> Any particular reason this wasn't applied?
>
> I ask because I added something similar recently to checkpatch.
It probably slipped through the cracks at the time the Coccinelle
scripts maintainer disappeared. I can check and see if it does anything
more than your script.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cocci script from 2016 - assignment in if ?
2020-06-25 6:49 ` Julia Lawall
@ 2020-06-25 7:49 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-06-25 7:49 UTC (permalink / raw)
To: Julia Lawall; +Cc: Kris Borer, Linux Kernel
On Thu, 2020-06-25 at 08:49 +0200, Julia Lawall wrote:
>
> On Wed, 24 Jun 2020, joe@perches.com wrote:
>
> > https://lore.kernel.org/patchwork/patch/649705/
> >
> > Any particular reason this wasn't applied?
> >
> > I ask because I added something similar recently to checkpatch.
>
> It probably slipped through the cracks at the time the Coccinelle
> scripts maintainer disappeared. I can check and see if it does anything
> more than your script.
The checkpatch thing only works on single lines,
so this cocci script looks more whitespace robust
but this script doesn't appear to handle code like
if (!(foo = bar(...)))
baz;
where the checkpatch thing converts it OK.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-25 7:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25 2:35 cocci script from 2016 - assignment in if ? joe
2020-06-25 6:49 ` Julia Lawall
2020-06-25 7:49 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox