From: Yonghong Song <yonghong.song@linux.dev>
To: Jiawei Zhao <phoenix500526@163.com>, ast@kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] libbpf: remove unused args in parse_usdt_note
Date: Wed, 3 Sep 2025 22:30:30 -0700 [thread overview]
Message-ID: <3b86ceb7-5dd4-4531-83cb-4b0229caae97@linux.dev> (raw)
In-Reply-To: <20250904030525.1932293-1-phoenix500526@163.com>
On 9/3/25 8:05 PM, Jiawei Zhao wrote:
> Remove unused 'elf' and 'path' parameters from parse_usdt_note function
> signature. These parameters are not referenced within the function body
> and only add unnecessary complexity.
>
> The function only requires the note header, data buffer, offsets, and
> output structure to perform USDT note parsing.
>
> Update function declaration, definition, and the single call site in
> collect_usdt_targets() to match the simplified signature.
>
> This is a safe internal cleanup as parse_usdt_note is a static function.
>
> Signed-off-by: Jiawei Zhao <phoenix500526@163.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2025-09-04 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 3:05 [PATCH v1] libbpf: remove unused args in parse_usdt_note Jiawei Zhao
2025-09-04 5:30 ` Yonghong Song [this message]
2025-09-04 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b86ceb7-5dd4-4531-83cb-4b0229caae97@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=phoenix500526@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox