From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Stuart Yoder <stuart.yoder@arm.com>,
linux-integrity@vger.kernel.org, peterhuewe@gmx.de,
sudeep.holla@arm.com, rafael@kernel.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] Add support for the TPM FF-A start method
Date: Tue, 04 Mar 2025 18:02:40 +0200 [thread overview]
Message-ID: <3b9141a372e9e787089a28beeb4bf11d5a144553.camel@kernel.org> (raw)
In-Reply-To: <20250303165535.GT5011@ziepe.ca>
On Mon, 2025-03-03 at 12:55 -0400, Jason Gunthorpe wrote:
> On Sun, Mar 02, 2025 at 09:33:59PM +0200, Jarkko Sakkinen wrote:
> > WARNING: line length of 102 exceeds 100 columns
> > #764: FILE: drivers/char/tpm/tpm_crb.c:821:
> > + FW_BUG "TPM2 ACPI table has wrong
> > size %u for start method type %d\n",
>
> Just ignore that, it is an error in checkpatch. Strings are required
> to
> be long. I suspect FW_BUG confused it.
Yep, as its own issue I think you are right.
I also noticed couple of additional style issues not picked
by checkpatch:
if (rc == -ENOENT) { // FF-A driver is not available yet
rc = -EPROBE_DEFER;
}
I.e. extra curly braces and "//" comment.
Should be:
/* If driver is not available yet, request probe retry: */
if (rc == -ENOENT)
rc = -EPROBE_DEFER;
>
> Jason
>
BR, Jarkko
next prev parent reply other threads:[~2025-03-04 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 22:49 [PATCH v4 0/5] Add support for the TPM FF-A start method Stuart Yoder
2025-02-17 22:49 ` [PATCH v4 1/5] tpm_crb: implement driver compliant to CRB over FF-A Stuart Yoder
2025-02-18 15:07 ` Jarkko Sakkinen
2025-02-17 22:49 ` [PATCH v4 2/5] tpm_crb: clean-up and refactor check for idle support Stuart Yoder
2025-02-18 15:52 ` Jarkko Sakkinen
2025-02-17 22:49 ` [PATCH v4 3/5] ACPICA: add start method for Arm FF-A Stuart Yoder
2025-02-18 15:53 ` Jarkko Sakkinen
2025-02-17 22:49 ` [PATCH v4 4/5] tpm_crb: add support for the Arm FF-A start method Stuart Yoder
2025-02-18 15:54 ` Jarkko Sakkinen
2025-02-17 22:49 ` [PATCH v4 5/5] Documentation: tpm: add documentation for the CRB FF-A interface Stuart Yoder
2025-03-02 19:33 ` [PATCH v4 0/5] Add support for the TPM FF-A start method Jarkko Sakkinen
2025-03-03 16:55 ` Jason Gunthorpe
2025-03-04 16:02 ` Jarkko Sakkinen [this message]
2025-03-05 16:09 ` Stuart Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9141a372e9e787089a28beeb4bf11d5a144553.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rafael@kernel.org \
--cc=stuart.yoder@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox