From: Markus Elfring <Markus.Elfring@web.de>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Cong Liu" <liucong2@kylinos.cn>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v2] platform/x86/amd/pmf: Fix memory leak in amd_pmf_get_pb_data()
Date: Mon, 29 Jan 2024 10:52:48 +0100 [thread overview]
Message-ID: <3ca56d3f-5a2b-4321-adbb-4e2c0d72b573@web.de> (raw)
In-Reply-To: <bbcf1b06-2a65-4f87-b15a-583a668dfc1e@redhat.com>
> If the question is: "Are patches generated by coccinelle welcome?"
> then the answer is "Yes patches generated by coccinelle are very
> much welcome".
How do you think about to fix a questionable memory leak
by using the function “memdup_user” instead?
https://elixir.bootlin.com/linux/v6.8-rc1/source/mm/util.c#L185
Would you like to try a corresponding command out once more on source files
of a software like “Linux next-20240125”?
https://elixir.bootlin.com/linux/v6.8-rc1/source/scripts/coccinelle/api/memdup_user.cocci#L2
make COCCI=scripts/coccinelle/api/memdup_user.cocci M=drivers/platform/x86/amd/pmf/ MODE=patch coccicheck
Regards,
Markus
prev parent reply other threads:[~2024-01-29 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 1:11 [PATCH] platform/x86/amd/pmf: Fix memory leak in amd_pmf_get_pb_data() Cong Liu
2024-01-23 14:37 ` Shyam Sundar S K
2024-01-24 1:29 ` [PATCH v2] " Cong Liu
2024-01-26 19:16 ` Hans de Goede
2024-01-28 10:45 ` [v2] " Markus Elfring
2024-01-29 8:59 ` Hans de Goede
2024-01-29 9:52 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ca56d3f-5a2b-4321-adbb-4e2c0d72b573@web.de \
--to=markus.elfring@web.de \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liucong2@kylinos.cn \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox