From: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571
Date: Tue, 9 Mar 2021 09:02:35 +0200 [thread overview]
Message-ID: <3cc37aec-bd27-235a-7c37-e8f1113c6a3c@linux.intel.com> (raw)
In-Reply-To: <20210228094424.7884-1-dinghao.liu@zju.edu.cn>
On 28/02/2021 11:44, Dinghao Liu wrote:
> There is one e1e_wphy() call in e1000_set_d0_lplu_state_82571
> that we have caught its return value but lack further handling.
> Check and terminate the execution flow just like other e1e_wphy()
> in this function.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c
> index 88faf05e23ba..0b1e890dd583 100644
> --- a/drivers/net/ethernet/intel/e1000e/82571.c
> +++ b/drivers/net/ethernet/intel/e1000e/82571.c
> @@ -899,6 +899,8 @@ static s32 e1000_set_d0_lplu_state_82571(struct e1000_hw *hw, bool active)
> } else {
> data &= ~IGP02E1000_PM_D0_LPLU;
> ret_val = e1e_wphy(hw, IGP02E1000_PHY_POWER_MGMT, data);
> + if (ret_val)
> + return ret_val;
> /* LPLU and SmartSpeed are mutually exclusive. LPLU is used
> * during Dx states where the power conservation is most
> * important. During driver activity we should enable
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
prev parent reply other threads:[~2021-03-09 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 9:44 [PATCH] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571 Dinghao Liu
2021-03-08 5:43 ` [Intel-wired-lan] " Neftin, Sasha
2021-03-09 7:02 ` Dvora Fuxbrumer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc37aec-bd27-235a-7c37-e8f1113c6a3c@linux.intel.com \
--to=dvorax.fuxbrumer@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox