public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Amandeep Singh <quic_amansing@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>, <andersson@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <mturquette@baylibre.com>
Cc: <quic_devipriy@quicinc.com>
Subject: Re: [PATCH] clk: qcom: ipq9574: Update the alpha PLL type for GPLLs
Date: Mon, 5 Aug 2024 14:41:16 +0530	[thread overview]
Message-ID: <3cca4d67-e420-442d-bb38-4eb0649dcdf4@quicinc.com> (raw)
In-Reply-To: <ff92343652a998b97981e63ea5dc301f.sboyd@kernel.org>

On 8/3/2024 6:35 AM, Stephen Boyd wrote:
> Quoting Amandeep Singh (2024-08-01 04:00:40)
>> From: devi priya <quic_devipriy@quicinc.com>
>>
>> Update PLL offsets to DEFAULT_EVO to configure MDIO to 800MHz.
> 
> Is this fixing a problem? I can't figure out how urgent this patch is
> from the one sentence commit text.

The incorrect clock frequency leads to an incorrect MDIO clock. This,
in turn, affects the MDIO hardware configurations as the divider is 
calculated from the MDIO clock frequency. If the clock frequency is
not as expected, the MDIO register fails due to the generation of an 
incorrect MDIO frequency.

This issue is critical as it results in incorrect MDIO configurations 
and ultimately leads to the MDIO function not working. This results in
a complete feature failure affecting all Ethernet PHYs. Specifically,
Ethernet will not work on IPQ9574 due to this issue.

Currently, the clock frequency is set to CLK_ALPHA_PLL_TYPE_DEFAULT. 
However, this setting does not yield the expected clock frequency. To 
rectify this, we need to change this to CLK_ALPHA_PLL_TYPE_DEFAULT_EVO.

This modification ensures that the clock frequency aligns with our 
expectations, thereby resolving the MDIO register failure and ensuring 
the proper functioning of the Ethernet on IPQ9574.

  reply	other threads:[~2024-08-05  9:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 11:00 [PATCH] clk: qcom: ipq9574: Update the alpha PLL type for GPLLs Amandeep Singh
2024-08-03  1:05 ` Stephen Boyd
2024-08-05  9:11   ` Amandeep Singh [this message]
2024-08-05 17:58     ` Stephen Boyd
  -- strict thread matches above, loose matches on Subject: below --
2024-08-06  6:11 Amandeep Singh
2024-08-15 20:40 ` Bjorn Andersson
2024-08-01 10:57 Amandeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cca4d67-e420-442d-bb38-4eb0649dcdf4@quicinc.com \
    --to=quic_amansing@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_devipriy@quicinc.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox