From: <Dharma.B@microchip.com>
To: <claudiu.beznea@tuxon.dev>, <Manikandan.M@microchip.com>,
<andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>,
<jonas@kwiboo.se>, <jernej.skrabec@gmail.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<Hari.PrasathGE@microchip.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource()
Date: Mon, 2 Sep 2024 08:35:47 +0000 [thread overview]
Message-ID: <3ceb248f-aa3a-4aa7-ac8b-dbfe9527f541@microchip.com> (raw)
In-Reply-To: <20240827161223.4152195-4-claudiu.beznea@tuxon.dev>
On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The devm_platform_ioremap_resouce() does exactly what
> devm_ioremap_resource() combined with platform_get_resouce() does.
> Thus use it.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-by: Dharma Balasubiramani <dharma.b@microchip.com>
Tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
> drivers/gpu/drm/bridge/microchip-lvds.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index f04831106eea..85aff8c5aaf4 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -154,8 +154,7 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>
> lvds->dev = dev;
>
> - lvds->regs = devm_ioremap_resource(lvds->dev,
> - platform_get_resource(pdev, IORESOURCE_MEM, 0));
> + lvds->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(lvds->regs))
> return PTR_ERR(lvds->regs);
>
> --
> 2.39.2
>
--
With Best Regards,
Dharma B.
prev parent reply other threads:[~2024-09-02 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 16:12 [PATCH 0/3] drm/bridge: microchip-lvds: Cleanups Claudiu Beznea
2024-08-27 16:12 ` [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure Claudiu Beznea
2024-09-02 4:39 ` Dharma.B
2024-09-02 8:18 ` claudiu beznea
2024-09-02 8:25 ` Dharma.B
2024-09-02 8:35 ` Dharma.B
2024-08-27 16:12 ` [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers Claudiu Beznea
2024-08-31 8:18 ` kernel test robot
2024-09-01 7:28 ` kernel test robot
2024-08-27 16:12 ` [PATCH 3/3] drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource() Claudiu Beznea
2024-09-02 4:39 ` Dharma.B
2024-09-02 8:35 ` Dharma.B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ceb248f-aa3a-4aa7-ac8b-dbfe9527f541@microchip.com \
--to=dharma.b@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Manikandan.M@microchip.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox