[PATCH 0/3] drm/bridge: microchip-lvds: Cleanups

[PATCH 0/3] drm/bridge: microchip-lvds: Cleanups

[Claudiu Beznea]

Hi,

Series adds few cleanups identified while looking though the driver.
Please note that these are compile test only.

Thank you,
Claudiu Beznea

Claudiu Beznea (3):
  drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of
    failure
  drm/bridge: microchip-lvds: Drop unused headers
  drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource()

 drivers/gpu/drm/bridge/microchip-lvds.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

-- 
2.39.2

[PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[Claudiu Beznea]

In case pm_runtime_get_sync() fails the clock remains enabled. Disable
it to save power on this failure scenario.

Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
---
 drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
index b8313dad6072..027292ab0197 100644
--- a/drivers/gpu/drm/bridge/microchip-lvds.c
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
 
 	ret = pm_runtime_get_sync(lvds->dev);
 	if (ret < 0) {
+		clk_disable_unprepare(lvds->pclk);
 		dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
 		return;
 	}
-- 
2.39.2

Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[Dharma.B]

On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
> it to save power on this failure scenario.
> 
> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-and-tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>   drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index b8313dad6072..027292ab0197 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
> 
>          ret = pm_runtime_get_sync(lvds->dev);
>          if (ret < 0) {
> +               clk_disable_unprepare(lvds->pclk);
>                  dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>                  return;
>          }
> --
> 2.39.2
> 


-- 
With Best Regards,
Dharma B.

Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[claudiu beznea]

On 02.09.2024 07:39, Dharma.B@microchip.com wrote:
> On 27/08/24 9:42 pm, Claudiu Beznea wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
>> it to save power on this failure scenario.
>>
>> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> Reviewed-and-tested-by: Dharma Balasubiramani <dharma.b@microchip.com>

This tag is not valid, AFAIK. You should use 2 different tags: Reviewed-by,
Tested-by

>> ---
>>   drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
>> index b8313dad6072..027292ab0197 100644
>> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
>> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
>> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
>>
>>          ret = pm_runtime_get_sync(lvds->dev);
>>          if (ret < 0) {
>> +               clk_disable_unprepare(lvds->pclk);
>>                  dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>>                  return;
>>          }
>> --
>> 2.39.2
>>
> 
> 

Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[Dharma.B]

Hi Claudiu,

On 02/09/24 1:48 pm, claudiu beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 02.09.2024 07:39, Dharma.B@microchip.com wrote:
>> On 27/08/24 9:42 pm, Claudiu Beznea wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
>>> it to save power on this failure scenario.
>>>
>>> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
>> Reviewed-and-tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> 
> This tag is not valid, AFAIK. You should use 2 different tags: Reviewed-by,
> Tested-by
Okay, I don't know how these got in

linux$ git log | grep Reviewed-and-tested-by
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@amd.com>
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@amd.com>
     Reviewed-and-tested-by: Raghavendra K T <raghavendra.kt@amd.com>
     Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
     Reviewed-and-tested-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
     Reviewed-and-tested-by: Chen Yu <yu.c.chen@intel.com>
     Reviewed-and-tested-by: Haibo Chen <haibo.chen@nxp.com>
     Reviewed-and-tested-by: Jingbo Xu <jefflexu@linux.alibaba.com>
     Reviewed-and-tested-by: Xiongwei Song <xiongwei.song@windriver.com>
     Reviewed-and-tested-by: Xiongwei Song <xiongwei.song@windriver.com>
     Reviewed-and-tested-by: Mathieu Desnoyers 
<mathieu.desnoyers@efficios.com>
     Reviewed-and-tested-by: Geliang Tang <geliang@kernel.org>
     Reviewed-and-tested-by: Geliang Tang <geliang@kernel.org>
     Reviewed-and-tested-by: Davidlohr Bueso <dave@stgolabs.net>
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@amd.com>
     Reviewed-and-tested-by: Wenjia Zhang <wenjia@linux.ibm.com>
     Reviewed-and-tested-by: Wenjia Zhang <wenjia@linux.ibm.com>
:
:
:
> 
>>> ---
>>>    drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> index b8313dad6072..027292ab0197 100644
>>> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
>>> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
>>>
>>>           ret = pm_runtime_get_sync(lvds->dev);
>>>           if (ret < 0) {
>>> +               clk_disable_unprepare(lvds->pclk);
>>>                   dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>>>                   return;
>>>           }
>>> --
>>> 2.39.2
>>>
>>
>>


-- 
With Best Regards,
Dharma B.

Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[Dharma.B]

On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
> it to save power on this failure scenario.
> 
> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-by: Dharma Balasubiramani <dharma.b@microchip.com>
Tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>   drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index b8313dad6072..027292ab0197 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
> 
>          ret = pm_runtime_get_sync(lvds->dev);
>          if (ret < 0) {
> +               clk_disable_unprepare(lvds->pclk);
>                  dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>                  return;
>          }
> --
> 2.39.2
> 


-- 
With Best Regards,
Dharma B.

[PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers

[Claudiu Beznea]

Drop unused headers. With this code becomes simpler.

Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
---
 drivers/gpu/drm/bridge/microchip-lvds.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
index 027292ab0197..f04831106eea 100644
--- a/drivers/gpu/drm/bridge/microchip-lvds.c
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -8,25 +8,16 @@
  */
 
 #include <linux/clk.h>
-#include <linux/component.h>
 #include <linux/delay.h>
 #include <linux/jiffies.h>
-#include <linux/mfd/syscon.h>
+#include <linux/of.h>
 #include <linux/of_graph.h>
-#include <linux/pinctrl/devinfo.h>
-#include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
-#include <linux/regmap.h>
-#include <linux/reset.h>
 
-#include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
-#include <drm/drm_print.h>
-#include <drm/drm_probe_helper.h>
-#include <drm/drm_simple_kms_helper.h>
 
 #define LVDS_POLL_TIMEOUT_MS 1000
 
-- 
2.39.2

Re: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers

[kernel test robot]

Hi Claudiu,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Claudiu-Beznea/drm-bridge-microchip-lvds-Revert-clk_prepare_enable-in-case-of-failure/20240828-001456
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240827161223.4152195-3-claudiu.beznea%40tuxon.dev
patch subject: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240831/202408311600.HvIve8JU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240831/202408311600.HvIve8JU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408311600.HvIve8JU-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/microchip-lvds.c: In function 'lvds_readl':
>> drivers/gpu/drm/bridge/microchip-lvds.c:62:16: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
      62 |         return readl_relaxed(lvds->regs + offset);
         |                ^~~~~~~~~~~~~
   drivers/gpu/drm/bridge/microchip-lvds.c: In function 'lvds_writel':
>> drivers/gpu/drm/bridge/microchip-lvds.c:67:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
      67 |         writel_relaxed(val, lvds->regs + offset);
         |         ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/readl_relaxed +62 drivers/gpu/drm/bridge/microchip-lvds.c

179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  59  
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  60  static inline u32 lvds_readl(struct mchp_lvds *lvds, u32 offset)
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  61  {
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21 @62  	return readl_relaxed(lvds->regs + offset);
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  63  }
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  64  
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  65  static inline void lvds_writel(struct mchp_lvds *lvds, u32 offset, u32 val)
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  66  {
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21 @67  	writel_relaxed(val, lvds->regs + offset);
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  68  }
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  69  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers

[kernel test robot]

Hi Claudiu,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Claudiu-Beznea/drm-bridge-microchip-lvds-Revert-clk_prepare_enable-in-case-of-failure/20240828-001456
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240827161223.4152195-3-claudiu.beznea%40tuxon.dev
patch subject: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240901/202409011412.DQVmnHIW-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/202409011412.DQVmnHIW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409011412.DQVmnHIW-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/microchip-lvds.c:62:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      62 |         return readl_relaxed(lvds->regs + offset);
         |                ^
>> drivers/gpu/drm/bridge/microchip-lvds.c:67:2: error: call to undeclared function 'writel_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      67 |         writel_relaxed(val, lvds->regs + offset);
         |         ^
   2 errors generated.


vim +/readl_relaxed +62 drivers/gpu/drm/bridge/microchip-lvds.c

179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  59  
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  60  static inline u32 lvds_readl(struct mchp_lvds *lvds, u32 offset)
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  61  {
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21 @62  	return readl_relaxed(lvds->regs + offset);
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  63  }
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  64  
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  65  static inline void lvds_writel(struct mchp_lvds *lvds, u32 offset, u32 val)
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  66  {
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21 @67  	writel_relaxed(val, lvds->regs + offset);
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  68  }
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  69  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH 3/3] drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource()

[Claudiu Beznea]

The devm_platform_ioremap_resouce() does exactly what
devm_ioremap_resource() combined with platform_get_resouce() does.
Thus use it.

Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
---
 drivers/gpu/drm/bridge/microchip-lvds.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
index f04831106eea..85aff8c5aaf4 100644
--- a/drivers/gpu/drm/bridge/microchip-lvds.c
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -154,8 +154,7 @@ static int mchp_lvds_probe(struct platform_device *pdev)
 
 	lvds->dev = dev;
 
-	lvds->regs = devm_ioremap_resource(lvds->dev,
-			platform_get_resource(pdev, IORESOURCE_MEM, 0));
+	lvds->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(lvds->regs))
 		return PTR_ERR(lvds->regs);
 
-- 
2.39.2

Re: [PATCH 3/3] drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource()

[Dharma.B]

On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The devm_platform_ioremap_resouce() does exactly what
> devm_ioremap_resource() combined with platform_get_resouce() does.
> Thus use it.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-and-tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>   drivers/gpu/drm/bridge/microchip-lvds.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index f04831106eea..85aff8c5aaf4 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -154,8 +154,7 @@ static int mchp_lvds_probe(struct platform_device *pdev)
> 
>          lvds->dev = dev;
> 
> -       lvds->regs = devm_ioremap_resource(lvds->dev,
> -                       platform_get_resource(pdev, IORESOURCE_MEM, 0));
> +       lvds->regs = devm_platform_ioremap_resource(pdev, 0);
>          if (IS_ERR(lvds->regs))
>                  return PTR_ERR(lvds->regs);
> 
> --
> 2.39.2
> 


-- 
With Best Regards,
Dharma B.

Re: [PATCH 3/3] drm/bridge: microchip-lvds: Use devm_platform_ioremap_resource()

[Dharma.B]

On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The devm_platform_ioremap_resouce() does exactly what
> devm_ioremap_resource() combined with platform_get_resouce() does.
> Thus use it.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Reviewed-by: Dharma Balasubiramani <dharma.b@microchip.com>
Tested-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>   drivers/gpu/drm/bridge/microchip-lvds.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index f04831106eea..85aff8c5aaf4 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -154,8 +154,7 @@ static int mchp_lvds_probe(struct platform_device *pdev)
> 
>          lvds->dev = dev;
> 
> -       lvds->regs = devm_ioremap_resource(lvds->dev,
> -                       platform_get_resource(pdev, IORESOURCE_MEM, 0));
> +       lvds->regs = devm_platform_ioremap_resource(pdev, 0);
>          if (IS_ERR(lvds->regs))
>                  return PTR_ERR(lvds->regs);
> 
> --
> 2.39.2
> 


-- 
With Best Regards,
Dharma B.