The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Xuanqiang Luo <xuanqiang.luo@linux.dev>
To: netdev@vger.kernel.org, andrew@lunn.ch,
	maxime.chevallier@bootlin.com, kuba@kernel.org
Cc: hkallweit1@gmail.com, qingfang.deng@siflower.com.cn,
	hao.guan@siflower.com.cn, linux@armlinux.org.uk,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	linux-kernel@vger.kernel.org,
	Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Subject: Re: [PATCH net v4 5/6] net: phy: propagate errors from default port setup
Date: Fri, 21 Aug 2026 17:42:02 +0800	[thread overview]
Message-ID: <3d9ee2ae-aa8d-41d3-b034-956c9003d2f2@linux.dev> (raw)
In-Reply-To: <20260821070327.16147-6-xuanqiang.luo@linux.dev>

在 2026/8/21 15:03, Xuanqiang Luo 写道:

> From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
>
> phy_default_setup_single_port() ignores errors from phy_add_port() and
> always reports success. If a PHY driver attach_mdi_port() callback fails,
> the phy_port is leaked and PHY probing continues without the expected
> default port.
>
> Destroy the port and return the error.
>
> Fixes: 589e934d2735 ("net: phy: Introduce PHY ports representation")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>

I realized I made a mistake.

The Reviewed-by tag added to patch 5/6 should be:

Maxime Chevallier <maxime.chevallier@bootlin.com>
rather than:
Andrew Lunn <andrew@lunn.ch>

Sorry for the mistake. I will send a corrected version after 24 hours.

Thanks,
Xuanqiang


  reply	other threads:[~2026-08-21  9:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  7:03 [PATCH net v4 0/6] net: phy: fix cleanup after probe failure Xuanqiang Luo
2026-08-21  7:03 ` [PATCH net v4 1/6] net: phy: split phy_probe() error paths Xuanqiang Luo
2026-08-21  7:03 ` [PATCH net v4 2/6] net: phy: unregister SFP upstream before port cleanup Xuanqiang Luo
2026-08-21  7:03 ` [PATCH net v4 3/6] net: phy: set PHY_READY after LED setup Xuanqiang Luo
2026-08-21  7:03 ` [PATCH net v4 4/6] net: phy: call driver remove when core initialization fails Xuanqiang Luo
2026-08-21  7:03 ` [PATCH net v4 5/6] net: phy: propagate errors from default port setup Xuanqiang Luo
2026-08-21  9:42   ` Xuanqiang Luo [this message]
2026-08-21  7:03 ` [PATCH net v4 6/6] net: phy: avoid double-free after LED trigger registration failure Xuanqiang Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d9ee2ae-aa8d-41d3-b034-956c9003d2f2@linux.dev \
    --to=xuanqiang.luo@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hao.guan@siflower.com.cn \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luoxuanqiang@kylinos.cn \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qingfang.deng@siflower.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox