public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Falkowski, Maciej" <maciej.falkowski@linux.intel.com>
To: Lizhi Hou <lizhi.hou@amd.com>,
	ogabbay@kernel.org, quic_jhugo@quicinc.com,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com,
	sonal.santan@amd.com, mario.limonciello@amd.com
Subject: Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation
Date: Thu, 13 Nov 2025 16:22:40 +0100	[thread overview]
Message-ID: <3ee3c7a6-65cc-4d67-9a4d-5b9b09e7908e@linux.intel.com> (raw)
In-Reply-To: <20251107181115.1293158-1-lizhi.hou@amd.com>

Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>

On 11/7/2025 7:11 PM, Lizhi Hou wrote:
> The mailbox interrupt register is not always cleared when a mailbox channel
> is created. This can leave stale interrupt states from previous operations.
>
> Fix this by explicitly clearing the interrupt register in the mailbox
> channel creation function.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 24258dcc18eb..858df97cd3fb 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
>   	}
>   
>   	mb_chann->bad_state = false;
> +	mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>   
>   	MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
>   	return mb_chann;

  reply	other threads:[~2025-11-13 15:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 18:11 [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation Lizhi Hou
2025-11-13 15:22 ` Falkowski, Maciej [this message]
2025-11-13 16:39   ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ee3c7a6-65cc-4d67-9a4d-5b9b09e7908e@linux.intel.com \
    --to=maciej.falkowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=mario.limonciello@amd.com \
    --cc=max.zhen@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox