* [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation
@ 2025-11-07 18:11 Lizhi Hou
2025-11-13 15:22 ` Falkowski, Maciej
0 siblings, 1 reply; 3+ messages in thread
From: Lizhi Hou @ 2025-11-07 18:11 UTC (permalink / raw)
To: ogabbay, quic_jhugo, maciej.falkowski, dri-devel
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan,
mario.limonciello
The mailbox interrupt register is not always cleared when a mailbox channel
is created. This can leave stale interrupt states from previous operations.
Fix this by explicitly clearing the interrupt register in the mailbox
channel creation function.
Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index 24258dcc18eb..858df97cd3fb 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
}
mb_chann->bad_state = false;
+ mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
return mb_chann;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation
2025-11-07 18:11 [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation Lizhi Hou
@ 2025-11-13 15:22 ` Falkowski, Maciej
2025-11-13 16:39 ` Lizhi Hou
0 siblings, 1 reply; 3+ messages in thread
From: Falkowski, Maciej @ 2025-11-13 15:22 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 11/7/2025 7:11 PM, Lizhi Hou wrote:
> The mailbox interrupt register is not always cleared when a mailbox channel
> is created. This can leave stale interrupt states from previous operations.
>
> Fix this by explicitly clearing the interrupt register in the mailbox
> channel creation function.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 24258dcc18eb..858df97cd3fb 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
> }
>
> mb_chann->bad_state = false;
> + mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>
> MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
> return mb_chann;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation
2025-11-13 15:22 ` Falkowski, Maciej
@ 2025-11-13 16:39 ` Lizhi Hou
0 siblings, 0 replies; 3+ messages in thread
From: Lizhi Hou @ 2025-11-13 16:39 UTC (permalink / raw)
To: Falkowski, Maciej, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Applied to drm-misc-next
On 11/13/25 07:22, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> On 11/7/2025 7:11 PM, Lizhi Hou wrote:
>> The mailbox interrupt register is not always cleared when a mailbox
>> channel
>> is created. This can leave stale interrupt states from previous
>> operations.
>>
>> Fix this by explicitly clearing the interrupt register in the mailbox
>> channel creation function.
>>
>> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>> drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c
>> b/drivers/accel/amdxdna/amdxdna_mailbox.c
>> index 24258dcc18eb..858df97cd3fb 100644
>> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
>> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
>> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
>> }
>> mb_chann->bad_state = false;
>> + mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>> MB_DBG(mb_chann, "Mailbox channel created (irq: %d)",
>> mb_chann->msix_irq);
>> return mb_chann;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-13 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-07 18:11 [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation Lizhi Hou
2025-11-13 15:22 ` Falkowski, Maciej
2025-11-13 16:39 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox