public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pantelis Antoniou <panto@intracom.gr>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tom Rini <trini@kernel.crashing.org>,
	Linuxppc-Embedded <linuxppc-embedded@lists.linuxppc.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix early request_irq
Date: Fri, 29 Oct 2004 17:20:13 +0300	[thread overview]
Message-ID: <4182519D.3020205@intracom.gr> (raw)
In-Reply-To: <20041029141648.GB25204@elte.hu>

Ingo Molnar wrote:

>* Pantelis Antoniou <panto@intracom.gr> wrote:
>
>  
>
>>Hi there
>>
>>The recent consolidation of the IRQ code has caused
>>a number of PPC embedded cpus to stop working.
>>
>>The problem is that on init_IRQ these platforms call
>>request_irq very early, which in turn calls kmalloc
>>without the memory subsystem being initialized.
>>
>>The following patch fixes it by keeping a small static
>>array of irqactions just for this purpose.
>>    
>>
>
>this is quite broken. Those places should use setup_irq(),
>not request_irq().
>
>	Ingo
>
>
>  
>
Sorry, didn't know about setup_irq.

Will fix.

Regards



  reply	other threads:[~2004-10-29 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 14:05 [PATCH] Fix early request_irq Pantelis Antoniou
2004-10-29 14:16 ` Ingo Molnar
2004-10-29 14:20   ` Pantelis Antoniou [this message]
2004-10-29 14:21 ` Christoph Hellwig
2004-10-29 16:11   ` Tom Rini
2004-11-01 17:41     ` Kumar Gala
2004-11-01 19:59       ` Tom Rini
2004-11-02  7:51         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4182519D.3020205@intracom.gr \
    --to=panto@intracom.gr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=mingo@elte.hu \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox