public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [sched-int-changes 3/5] add_requeue_task
@ 2004-11-06 10:35 Con Kolivas
  0 siblings, 0 replies; only message in thread
From: Con Kolivas @ 2004-11-06 10:35 UTC (permalink / raw)
  To: linux; +Cc: Andrew Morton, Ingo Molnar


[-- Attachment #1.1: Type: text/plain, Size: 63 bytes --]

add_requeue_task

Please include in at least one -mm release.


[-- Attachment #1.2: sched-add_requeue_task.diff --]
[-- Type: text/x-patch, Size: 1750 bytes --]

We can requeue tasks for cheaper then doing a complete dequeue followed by
an enqueue. Add the requeue_task function and perform it where possible.

This will be hit frequently by upcoming changes to the requeueing in
timeslice granularity.

Signed-off-by: Con Kolivas <kernel@kolivas.org>

Index: linux-2.6.10-rc1-mm3/kernel/sched.c
===================================================================
--- linux-2.6.10-rc1-mm3.orig/kernel/sched.c	2004-11-05 20:56:46.608179150 +1100
+++ linux-2.6.10-rc1-mm3/kernel/sched.c	2004-11-05 20:57:14.376900024 +1100
@@ -593,6 +593,15 @@ static void enqueue_task(struct task_str
 }
 
 /*
+ * Put task to the end of the run list without the overhead of dequeue
+ * followed by enqueue.
+ */
+static void requeue_task(struct task_struct *p, prio_array_t *array)
+{
+	list_move_tail(&p->run_list, array->queue + p->prio);
+}
+
+/*
  * Used by the migration code - we pull tasks from the head of the
  * remote queue so we want these tasks to show up at the head of the
  * local queue:
@@ -2456,8 +2465,7 @@ void scheduler_tick(void)
 			set_tsk_need_resched(p);
 
 			/* put it at the end of the queue: */
-			dequeue_task(p, rq->active);
-			enqueue_task(p, rq->active);
+			requeue_task(p, rq->active);
 		}
 		goto out_unlock;
 	}
@@ -3605,8 +3613,14 @@ asmlinkage long sys_sched_yield(void)
 	} else if (!rq->expired->nr_active)
 		schedstat_inc(rq, yld_exp_empty);
 
-	dequeue_task(current, array);
-	enqueue_task(current, target);
+	if (array != target) {
+		dequeue_task(current, array);
+		enqueue_task(current, target);
+	} else
+		/*
+		 * requeue_task is cheaper so perform that if possible.
+		 */
+		requeue_task(current, array);
 
 	/*
 	 * Since we are going to call schedule() anyway, there's


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-11-06 10:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-06 10:35 [PATCH] [sched-int-changes 3/5] add_requeue_task Con Kolivas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox