From: Brian Gerst <bgerst@didntduck.org>
To: Liam Girdwood <Liam.Girdwood@wolfsonmicro.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] AC97 plugin suspend/resume
Date: Tue, 04 Jan 2005 10:07:42 -0500 [thread overview]
Message-ID: <41DAB13E.40208@didntduck.org> (raw)
In-Reply-To: <1104850247.9143.335.camel@cearnarfon>
Liam Girdwood wrote:
> This patch sets suspend and resume to NULL in the ad1980 plugin.
>
> Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
>
> Liam
>
>
> ------------------------------------------------------------------------
>
> --- a/sound/oss/ac97_plugin_ad1980.c 2004-12-24 21:33:48.000000000 +0000
> +++ b/sound/oss/ac97_plugin_ad1980.c 2005-01-04 14:15:40.000000000 +0000
> @@ -89,6 +89,8 @@
> .name = "AD1980 example",
> .probe = ad1980_probe,
> .remove = __devexit_p(ad1980_remove),
> + .suspend = NULL,
> + .resume = NULL,
> };
>
> /**
There is really no reason to add these fields if they are NULL. Zero
(or NULL for pointers) is the default for all unspecified fields, and it
is kernel convention to use this feature to reduce clutter.
--
Brian Gerst
next prev parent reply other threads:[~2005-01-04 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 14:50 [PATCH 2/2] AC97 plugin suspend/resume Liam Girdwood
2005-01-04 15:07 ` Brian Gerst [this message]
2005-01-04 15:28 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DAB13E.40208@didntduck.org \
--to=bgerst@didntduck.org \
--cc=Liam.Girdwood@wolfsonmicro.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox