* [PATCH 2/2] AC97 plugin suspend/resume
@ 2005-01-04 14:50 Liam Girdwood
2005-01-04 15:07 ` Brian Gerst
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2005-01-04 14:50 UTC (permalink / raw)
To: Alan Cox; +Cc: lkml
[-- Attachment #1: Type: text/plain, Size: 134 bytes --]
This patch sets suspend and resume to NULL in the ad1980 plugin.
Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Liam
[-- Attachment #2: ac97_plugin_ad1980.diff --]
[-- Type: text/x-patch, Size: 309 bytes --]
--- a/sound/oss/ac97_plugin_ad1980.c 2004-12-24 21:33:48.000000000 +0000
+++ b/sound/oss/ac97_plugin_ad1980.c 2005-01-04 14:15:40.000000000 +0000
@@ -89,6 +89,8 @@
.name = "AD1980 example",
.probe = ad1980_probe,
.remove = __devexit_p(ad1980_remove),
+ .suspend = NULL,
+ .resume = NULL,
};
/**
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] AC97 plugin suspend/resume
2005-01-04 14:50 [PATCH 2/2] AC97 plugin suspend/resume Liam Girdwood
@ 2005-01-04 15:07 ` Brian Gerst
2005-01-04 15:28 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Brian Gerst @ 2005-01-04 15:07 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Alan Cox, lkml
Liam Girdwood wrote:
> This patch sets suspend and resume to NULL in the ad1980 plugin.
>
> Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
>
> Liam
>
>
> ------------------------------------------------------------------------
>
> --- a/sound/oss/ac97_plugin_ad1980.c 2004-12-24 21:33:48.000000000 +0000
> +++ b/sound/oss/ac97_plugin_ad1980.c 2005-01-04 14:15:40.000000000 +0000
> @@ -89,6 +89,8 @@
> .name = "AD1980 example",
> .probe = ad1980_probe,
> .remove = __devexit_p(ad1980_remove),
> + .suspend = NULL,
> + .resume = NULL,
> };
>
> /**
There is really no reason to add these fields if they are NULL. Zero
(or NULL for pointers) is the default for all unspecified fields, and it
is kernel convention to use this feature to reduce clutter.
--
Brian Gerst
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] AC97 plugin suspend/resume
2005-01-04 15:07 ` Brian Gerst
@ 2005-01-04 15:28 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2005-01-04 15:28 UTC (permalink / raw)
To: Brian Gerst; +Cc: Alan Cox, lkml
On Tue, 2005-01-04 at 15:07, Brian Gerst wrote:
> There is really no reason to add these fields if they are NULL. Zero
> (or NULL for pointers) is the default for all unspecified fields, and it
> is kernel convention to use this feature to reduce clutter.
>
Ok, patch 2/2 can be safely ignored. It was added for clarity.
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-04 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-04 14:50 [PATCH 2/2] AC97 plugin suspend/resume Liam Girdwood
2005-01-04 15:07 ` Brian Gerst
2005-01-04 15:28 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox