2.6.11-rc5-mm1 nfs oddity, file creation => "no such file"

2.6.11-rc5-mm1 nfs oddity, file creation => "no such file"

[Helge Hafting]

I observed an oddity on a nfs-mounted fs while using 2.6.11-rc5-mm1.

I tried to save a file from xfig, and got an error message about a
nonexisting file.  Now apps may have their own bugs, so I
retried in the shell:

$ cat > newfile
newfile: No such file or directory
$

Eh - of course it didn't exist - I was trying to create it!

This also resulted in "newfile" being created with size 0.
Repeating the "cat > newfile" worked fine once the zero-length
file existed.  Unfortunately, xfig always removes files before overwriting
so it couldn't save on the nfs volume at all.

File creation by "touch filename" worked flawlessly.

After this I rebooted into 2.6.11-rc3-mm1 which haven't shown this problem
so far.  There were nothing in "dmesg" when this happened, other
than a message about "mount" being older than the kernel.

I can try to recreate the problem if necessary.

Helge Hafting

Re: 2.6.11-rc5-mm1 nfs oddity, file creation => "no such file"

[Andrew Morton]

Helge Hafting <helgehaf@aitel.hist.no> wrote:
>
> I observed an oddity on a nfs-mounted fs while using 2.6.11-rc5-mm1.

Could you try this please?

--- 25/fs/nfs/nfs3proc.c~nfsacl-acl-umask-handling-workaround-in-nfs-client-fix	2005-03-02 08:49:59.000000000 -0800
+++ 25-akpm/fs/nfs/nfs3proc.c	2005-03-02 08:49:59.000000000 -0800
@@ -423,6 +423,9 @@ exit:
 		if (!inode)
 			goto out;
 		status = nfs3_set_default_acl(dir, inode, mode);
+		if (status)
+			goto out;
+		return inode;
 	}
 out:
 	return ERR_PTR(status);
_

Re: 2.6.11-rc5-mm1 nfs oddity, file creation => "no such file"

[Helge Hafting]

Andrew Morton wrote:

>Helge Hafting <helgehaf@aitel.hist.no> wrote:
>  
>
>>I observed an oddity on a nfs-mounted fs while using 2.6.11-rc5-mm1.
>>    
>>
>
>Could you try this please?
>
>--- 25/fs/nfs/nfs3proc.c~nfsacl-acl-umask-handling-workaround-in-nfs-client-fix	2005-03-02 08:49:59.000000000 -0800
>+++ 25-akpm/fs/nfs/nfs3proc.c	2005-03-02 08:49:59.000000000 -0800
>@@ -423,6 +423,9 @@ exit:
> 		if (!inode)
> 			goto out;
> 		status = nfs3_set_default_acl(dir, inode, mode);
>+		if (status)
>+			goto out;
>+		return inode;
> 	}
> out:
> 	return ERR_PTR(status);
>_
>
>  
>
"cat > some_new_file" worked fine on NFS with this patch.  I'll keep using
nfs at work with this.

Helge Hafting