[TRIVAL] Runtime linkage fix for serial_cs

[TRIVAL] Runtime linkage fix for serial_cs

[Takeharu KATO]

Hi

I found current serial_cs driver can not be loaded into the kernel.
The reason of this issue is serial_cs driver uses serial8250_unregister_port function
which is not exported for modules.
I fixed the issue, please apply this patch.

Signed-off-by: kato.takeharu@jp.fujitsu.com

diff -NBbur linux.orig/drivers/serial/serial_cs.c linux/drivers/serial/serial_cs.c
--- linux.orig/drivers/serial/serial_cs.c    2005-06-27 15:06:42.000000000 +0900
+++ linux/drivers/serial/serial_cs.c 2005-08-24 00:16:09.297664592 +0900
@@ -139,7 +139,7 @@
          */
         if (info->link.state & DEV_CONFIG) {
                 for (i = 0; i < info->ndev; i++)
-                       serial8250_unregister_port(info->line[i]);
+                       unregister_serial(info->line[i]);

                 info->link.dev = NULL;

Re: [TRIVAL] Runtime linkage fix for serial_cs

[Russell King]

On Sat, Sep 03, 2005 at 05:49:23PM +0900, Takeharu KATO wrote:
> I found current serial_cs driver can not be loaded into the kernel.
> The reason of this issue is serial_cs driver uses serial8250_unregister_port
> function which is not exported for modules.

Your kernel sources are buggy.  This function is exported.

> I fixed the issue, please apply this patch.

This is not a fix - unregister_serial() must not be used with ports
registered with serial8250_register_port(), and in fact
unregister_serial() no longer exists.

You need to find out why your tree doesn't export
serial8250_unregister_port().  Mis-merged patch maybe?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Re: [TRIVAL] Runtime linkage fix for serial_cs

[Takeharu KATO]

Hi

> You need to find out why your tree doesn't export
> serial8250_unregister_port().  Mis-merged patch maybe?
> 
Thank you for your response.
I'll check our kernel again.