* [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
@ 2005-09-19 11:22 Grant Coady
2005-09-26 21:35 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Grant Coady @ 2005-09-19 11:22 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
Greetings,
This patch cleans up pci_ids.h, reducing size of the file from
104448 to 73438 bytes. Due to the scripted changes and the
requirement to maintain ordering within the file I had to reformat
whitespace.
Compile tested with 'make allmodconfig' with some stuff turned
off to get a compile completion. No missing PCI_* symbols.
Next step is to fix PCI_* defines distributed in the source, also
this file is meant to be included via 'pci.h' some files may need a
reference to pci_ids.h removed.
As attachment as patch is 92k.
Thanks,
Grant.
[-- Attachment #2: pci_ids.h-cleanup-rm-unused-syms-and-format.diff.gz --]
[-- Type: application/octet-stream, Size: 18446 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
2005-09-19 11:22 [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries Grant Coady
@ 2005-09-26 21:35 ` Greg KH
2005-09-27 8:32 ` Grant Coady
2005-09-27 21:23 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2005-09-26 21:35 UTC (permalink / raw)
To: Grant Coady; +Cc: linux-kernel
On Mon, Sep 19, 2005 at 09:22:36PM +1000, Grant Coady wrote:
> Greetings,
>
> This patch cleans up pci_ids.h, reducing size of the file from
> 104448 to 73438 bytes. Due to the scripted changes and the
> requirement to maintain ordering within the file I had to reformat
> whitespace.
>
> Compile tested with 'make allmodconfig' with some stuff turned
> off to get a compile completion. No missing PCI_* symbols.
>
> Next step is to fix PCI_* defines distributed in the source, also
> this file is meant to be included via 'pci.h' some files may need a
> reference to pci_ids.h removed.
>
> As attachment as patch is 92k.
I don't think you need the change to the comments at the top of the
file.
Also, I thought we wanted to keep all of the pci class ids, why did you
delete them? We should start by removing the pci device and vendor ids
that are not currently used by the kernel, and then slowly move those
ids into the individual drivers, starting with the device ids, and maybe
eventually moving to the vendor ids.
Sound ok?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
2005-09-26 21:35 ` Greg KH
@ 2005-09-27 8:32 ` Grant Coady
2005-09-27 8:36 ` Greg KH
2005-09-27 21:23 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Grant Coady @ 2005-09-27 8:32 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
On Mon, 26 Sep 2005 14:35:57 -0700, Greg KH <greg@kroah.com> wrote:
>I don't think you need the change to the comments at the top of the
>file.
Okay
>Also, I thought we wanted to keep all of the pci class ids, why did you
>delete them?
I'll give 'em back then ;)
> We should start by removing the pci device and vendor ids
>that are not currently used by the kernel, and then slowly move those
>ids into the individual drivers, starting with the device ids, and maybe
>eventually moving to the vendor ids.
>
>Sound ok?
Yep, I'll go find that script, bash it some more... I'll leave the
whitespace cleanup to last, since we gonna delete most of pci_ids.h?
Thanks,
Grant.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
2005-09-27 8:32 ` Grant Coady
@ 2005-09-27 8:36 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2005-09-27 8:36 UTC (permalink / raw)
To: Grant Coady; +Cc: linux-kernel
On Tue, Sep 27, 2005 at 06:32:12PM +1000, Grant Coady wrote:
> On Mon, 26 Sep 2005 14:35:57 -0700, Greg KH <greg@kroah.com> wrote:
> > We should start by removing the pci device and vendor ids
> >that are not currently used by the kernel, and then slowly move those
> >ids into the individual drivers, starting with the device ids, and maybe
> >eventually moving to the vendor ids.
> >
> >Sound ok?
>
> Yep, I'll go find that script, bash it some more... I'll leave the
> whitespace cleanup to last, since we gonna delete most of pci_ids.h?
Yes, that is the goal.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
2005-09-26 21:35 ` Greg KH
2005-09-27 8:32 ` Grant Coady
@ 2005-09-27 21:23 ` Jeff Garzik
2005-09-27 22:04 ` Grant Coady
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2005-09-27 21:23 UTC (permalink / raw)
To: Greg KH; +Cc: Grant Coady, linux-kernel
Greg KH wrote:
> I don't think you need the change to the comments at the top of the
> file.
agreed.
> Also, I thought we wanted to keep all of the pci class ids, why did you
> delete them? We should start by removing the pci device and vendor ids
> that are not currently used by the kernel, and then slowly move those
> ids into the individual drivers, starting with the device ids, and maybe
> eventually moving to the vendor ids.
The vendor ids are OBVIOUSLY common constants. The proper place is
where they live now: pci_ids.h.
I see little value in moving referenced device ids into individual
drivers, as they will make them harder to grep for, as time passes.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
2005-09-27 21:23 ` Jeff Garzik
@ 2005-09-27 22:04 ` Grant Coady
0 siblings, 0 replies; 6+ messages in thread
From: Grant Coady @ 2005-09-27 22:04 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Greg KH, linux-kernel
On Tue, 27 Sep 2005 17:23:08 -0400, Jeff Garzik <jgarzik@pobox.com> wrote:
>Greg KH wrote:
[...]
>> We should start by removing the pci device and vendor ids
>> that are not currently used by the kernel, and then slowly move those
>> ids into the individual drivers, starting with the device ids, and maybe
>> eventually moving to the vendor ids.
>
>The vendor ids are OBVIOUSLY common constants. The proper place is
>where they live now: pci_ids.h.
>
>I see little value in moving referenced device ids into individual
>drivers, as they will make them harder to grep for, as time passes.
Hi Jeff,
Couple weeks ago you wrote:
>Long term, we should be able to trim a lot of device ids, since they are
>usually only used in one place.
What did you mean here? Trim from where?
Currently I have about 2011 symbols in the source, and 2040 in pci_ids.h,
with about 15 duplicates (likely the macro #define ones).
The situation is like the donkey between the hay bales.
Which way?
In meantime I'll continue to document current practice here:
http://bugsplatter.mine.nu/kernel/pci_ids/
Thanks,
Grant.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-09-27 22:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-19 11:22 [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries Grant Coady
2005-09-26 21:35 ` Greg KH
2005-09-27 8:32 ` Grant Coady
2005-09-27 8:36 ` Greg KH
2005-09-27 21:23 ` Jeff Garzik
2005-09-27 22:04 ` Grant Coady
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox