From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
markgross@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] platform/x86: ISST : Check major minor version
Date: Mon, 2 Oct 2023 16:49:04 +0300 (EEST) [thread overview]
Message-ID: <45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com> (raw)
In-Reply-To: <72a2766bc7bb4f9d6b3d5f2ff114f0af1b6646a4.camel@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Sat, 30 Sep 2023, srinivas pandruvada wrote:
> On Fri, 2023-09-29 at 17:28 +0300, Ilpo Järvinen wrote:
> > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:
> >
> > > Parse major and minor version number from the version field. If
> > > there
> > > is a mismatch for major version, exit from further processing for
> > > that
> > > domain.
> > >
> > > If there is mismatch in minor version, driver continue to process
> > > with
> > > an error message.
> >
> > This sentence sounds odd.
> What is the suggestion here?
These things sound wrong: It should be "continues" but I also find "to
process" odd when lacking what it processes.
--
i.
next prev parent reply other threads:[~2023-10-02 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 19:43 [PATCH 0/3] TPMI feature major/minor version check Srinivas Pandruvada
2023-09-25 19:43 ` [PATCH 1/3] platform/x86/intel/tpmi: Add defines to get version information Srinivas Pandruvada
2023-09-25 19:43 ` [PATCH 2/3] platform/x86: ISST : Check major minor version Srinivas Pandruvada
2023-09-29 14:28 ` Ilpo Järvinen
2023-09-29 14:33 ` Ilpo Järvinen
2023-09-30 12:45 ` srinivas pandruvada
2023-09-30 12:42 ` srinivas pandruvada
2023-10-02 13:49 ` Ilpo Järvinen [this message]
2023-10-02 13:54 ` srinivas pandruvada
2023-10-02 14:24 ` Ilpo Järvinen
2023-10-02 14:56 ` srinivas pandruvada
2023-09-25 19:43 ` [PATCH 3/3] platform/x86/intel-uncore-freq: " Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox