From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
markgross@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] platform/x86: ISST : Check major minor version
Date: Mon, 02 Oct 2023 06:54:56 -0700 [thread overview]
Message-ID: <daa44585c4a57b8823cb260d9ec9bd3f59f410c6.camel@linux.intel.com> (raw)
In-Reply-To: <45625e9e-997b-eba1-413a-43a7d835feb@linux.intel.com>
On Mon, 2023-10-02 at 16:49 +0300, Ilpo Järvinen wrote:
> On Sat, 30 Sep 2023, srinivas pandruvada wrote:
>
> > On Fri, 2023-09-29 at 17:28 +0300, Ilpo Järvinen wrote:
> > > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote:
> > >
> > > > Parse major and minor version number from the version field. If
> > > > there
> > > > is a mismatch for major version, exit from further processing
> > > > for
> > > > that
> > > > domain.
> > > >
> > > > If there is mismatch in minor version, driver continue to
> > > > process
> > > > with
> > > > an error message.
> > >
> > > This sentence sounds odd.
> > What is the suggestion here?
>
> These things sound wrong: It should be "continues"
OK
> but I also find "to
> process" odd when lacking what it processes.
Further processing means, whatever this driver is supposed to do. You
don't want to fully explain again what this driver is doing.
>
next prev parent reply other threads:[~2023-10-02 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 19:43 [PATCH 0/3] TPMI feature major/minor version check Srinivas Pandruvada
2023-09-25 19:43 ` [PATCH 1/3] platform/x86/intel/tpmi: Add defines to get version information Srinivas Pandruvada
2023-09-25 19:43 ` [PATCH 2/3] platform/x86: ISST : Check major minor version Srinivas Pandruvada
2023-09-29 14:28 ` Ilpo Järvinen
2023-09-29 14:33 ` Ilpo Järvinen
2023-09-30 12:45 ` srinivas pandruvada
2023-09-30 12:42 ` srinivas pandruvada
2023-10-02 13:49 ` Ilpo Järvinen
2023-10-02 13:54 ` srinivas pandruvada [this message]
2023-10-02 14:24 ` Ilpo Järvinen
2023-10-02 14:56 ` srinivas pandruvada
2023-09-25 19:43 ` [PATCH 3/3] platform/x86/intel-uncore-freq: " Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa44585c4a57b8823cb260d9ec9bd3f59f410c6.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).