* [PATCH] hrtimers: fix HRTIMER_CB_IRQSAFE_NO_SOFTIRQ description
@ 2007-03-04 11:26 Andres Salomon
0 siblings, 0 replies; 3+ messages in thread
From: Andres Salomon @ 2007-03-04 11:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: Thomas Gleixner, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
The description for HRTIMER_CB_IRQSAFE_NO_SOFTIRQ is backwards; "NO
SOFTIRQ" sounds a whole lot like it means it must not be run in a
softirq. :)
[-- Attachment #2: hrtimer1.patch --]
[-- Type: text/x-patch, Size: 579 bytes --]
diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
index 3bef961..b9f163d 100644
--- a/include/linux/hrtimer.h
+++ b/include/linux/hrtimer.h
@@ -47,7 +47,7 @@ enum hrtimer_restart {
* HRTIMER_CB_IRQSAFE: Callback may run in hardirq context
* HRTIMER_CB_IRQSAFE_NO_RESTART: Callback may run in hardirq context and
* does not restart the timer
- * HRTIMER_CB_IRQSAFE_NO_SOFTIRQ: Callback must run in softirq context
+ * HRTIMER_CB_IRQSAFE_NO_SOFTIRQ: Callback must run in hardirq context
* Special mode for tick emultation
*/
enum hrtimer_cb_mode {
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] hrtimers: fix HRTIMER_CB_IRQSAFE_NO_SOFTIRQ description
@ 2007-03-04 12:47 Andres Salomon
2007-03-04 12:57 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Andres Salomon @ 2007-03-04 12:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: Thomas Gleixner, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
The description for HRTIMER_CB_IRQSAFE_NO_SOFTIRQ is backwards; "NO
SOFTIRQ" sounds a whole lot like it means it must not be run in a
softirq. :)
(Resending; forgot to sign off)
Signed-off-by: Andres Salomon <dilinger@debian.org>
[-- Attachment #2: hrtimer1.patch --]
[-- Type: text/x-patch, Size: 579 bytes --]
diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
index 3bef961..b9f163d 100644
--- a/include/linux/hrtimer.h
+++ b/include/linux/hrtimer.h
@@ -47,7 +47,7 @@ enum hrtimer_restart {
* HRTIMER_CB_IRQSAFE: Callback may run in hardirq context
* HRTIMER_CB_IRQSAFE_NO_RESTART: Callback may run in hardirq context and
* does not restart the timer
- * HRTIMER_CB_IRQSAFE_NO_SOFTIRQ: Callback must run in softirq context
+ * HRTIMER_CB_IRQSAFE_NO_SOFTIRQ: Callback must run in hardirq context
* Special mode for tick emultation
*/
enum hrtimer_cb_mode {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hrtimers: fix HRTIMER_CB_IRQSAFE_NO_SOFTIRQ description
2007-03-04 12:47 Andres Salomon
@ 2007-03-04 12:57 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2007-03-04 12:57 UTC (permalink / raw)
To: Andres Salomon; +Cc: Andrew Morton, linux-kernel
On Sun, 2007-03-04 at 07:47 -0500, Andres Salomon wrote:
> The description for HRTIMER_CB_IRQSAFE_NO_SOFTIRQ is backwards; "NO
> SOFTIRQ" sounds a whole lot like it means it must not be run in a
> softirq. :)
>
> (Resending; forgot to sign off)
>
> Signed-off-by: Andres Salomon <dilinger@debian.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-04 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-04 11:26 [PATCH] hrtimers: fix HRTIMER_CB_IRQSAFE_NO_SOFTIRQ description Andres Salomon
-- strict thread matches above, loose matches on Subject: below --
2007-03-04 12:47 Andres Salomon
2007-03-04 12:57 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox