* DC390: replace pci_module_init in dc390_module_init
@ 2007-05-05 12:28 Niklas Steinkamp
2007-05-05 20:23 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Steinkamp @ 2007-05-05 12:28 UTC (permalink / raw)
To: garloff, linux-kernel
Hi,
while compiling the DC930 SCSI driver, i got this message:
drivers/built-in.o: In function `dc390_module_init':
tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
make: *** [.tmp_vmlinux1] Fehler 1
so i replaced "pci_module_init" with "pci_register_device"
and it works just fine.
--------------------------
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
printk (KERN_INFO "DC390: Using safe settings.\n");
}
- return pci_module_init(&dc390_driver);
+ return pci_register_driver(&dc390_driver);
}
static void __exit dc390_module_exit(void)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: DC390: replace pci_module_init in dc390_module_init
2007-05-05 12:28 DC390: replace pci_module_init in dc390_module_init Niklas Steinkamp
@ 2007-05-05 20:23 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2007-05-05 20:23 UTC (permalink / raw)
To: Niklas Steinkamp; +Cc: garloff, linux-kernel
On Sat, 5 May 2007, Niklas Steinkamp wrote:
> while compiling the DC930 SCSI driver, i got this message:
>
> drivers/built-in.o: In function `dc390_module_init':
> tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
> make: *** [.tmp_vmlinux1] Fehler 1
>
> so i replaced "pci_module_init" with "pci_register_device"
> and it works just fine.
> --------------------------
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index a583e89..3158949 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
> printk (KERN_INFO "DC390: Using safe settings.\n");
> }
>
> - return pci_module_init(&dc390_driver);
> + return pci_register_driver(&dc390_driver);
> }
>
> static void __exit dc390_module_exit(void)
Thanks for the patch, but this is already fixed in -mm tree:
http://marc.info/?l=linux-scsi&m=117757368229767&w=2
Thanks
Guennadi
---
Guennadi Liakhovetski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-05 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-05 12:28 DC390: replace pci_module_init in dc390_module_init Niklas Steinkamp
2007-05-05 20:23 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox