From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: ego@in.ibm.com
Cc: Pavel Machek <pavel@ucw.cz>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
rjw@sisk.pl, James.Bottomley@SteelEye.com,
aneesh.kumar@gmail.com, drzeus@drzeus.cx, dwmw2@infradead.org,
greg@kroah.com, mingo@elte.hu, neilb@suse.de, oleg@tv-sign.ru,
paulmck@linux.vnet.ibm.com, vatsa@in.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch 128/197] freezer: add try_to_freeze calls to all kernel threads
Date: Wed, 09 May 2007 15:20:47 +0200 [thread overview]
Message-ID: <4641CAAF.8060103@s5r6.in-berlin.de> (raw)
In-Reply-To: <20070509121641.GA27109@in.ibm.com>
Gautham R Shenoy wrote:
> freezer_exempt() as of now does what its name says. I.e, exempt the
> thread from all kinds of freeze chills.
>
> But with more subsystems using the process freezer, the exemption needs
> to be event specific. There may be threads which should not be frozen
> for say kprobes, should be frozen for cpu-hotplug. This selective
> freezing is not yet available. But it will be soon...
Thanks for the (necessary!) clarification.
Let me point out that the usual process would be to replace
freezer_exempt(current);
for (;;) {
...;
by
freezer_exempt_for_io(current);
for (;;) {
try_to_freeze();
...;
when or after freezer_exempt_for_io was implemented.
But as it was submitted now, we are temporarily left with
freezer_exempt(current);
for (;;) {
try_to_freeze(); /* useless irritating no-op */
...;
without any benefit. (And this explanatory comment ^^^ wasn't even
added; we only have the git log as explanation.)
As subsystem maintainer I have to trust now that "soon" actually means
"soon" and not "RSN"; otherwise my responsibility would be to send a NAK.
--
Stefan Richter
-=====-=-=== -=-= -=--=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-05-09 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705090934.l499YTvX019783@shell0.pdx.osdl.net>
2007-05-09 10:44 ` [patch 128/197] freezer: add try_to_freeze calls to all kernel threads Stefan Richter
2007-05-09 10:49 ` Pavel Machek
2007-05-09 12:06 ` Stefan Richter
2007-05-09 12:16 ` Gautham R Shenoy
2007-05-09 13:20 ` Stefan Richter [this message]
2007-05-09 15:29 ` Gautham R Shenoy
2007-05-09 18:18 ` Rafael J. Wysocki
2007-05-09 18:48 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4641CAAF.8060103@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@gmail.com \
--cc=drzeus@drzeus.cx \
--cc=dwmw2@infradead.org \
--cc=ego@in.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=oleg@tv-sign.ru \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox