pxamci.c fails to compile

pxamci.c fails to compile

[Mike Rapoport]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

The PXA MMC controller does not compile for PXA27x after MMC
reorganization, because it uses protocol defines to implement HW erratum
workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
The following patch fixes it


-- 
Sincerely yours,
Mike.



[-- Attachment #2: mmc_fix.patch --]
[-- Type: text/x-patch, Size: 343 bytes --]

diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index d97d386..00fc99f 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -24,6 +24,7 @@
 #include <linux/interrupt.h>
 #include <linux/dma-mapping.h>
 #include <linux/mmc/host.h>
+#include <linux/mmc/mmc.h>
 
 #include <asm/dma.h>
 #include <asm/io.h>

Re: pxamci.c fails to compile

[Russell King]

On Mon, May 14, 2007 at 11:22:04AM +0300, Mike Rapoport wrote:
> The PXA MMC controller does not compile for PXA27x after MMC
> reorganization, because it uses protocol defines to implement HW erratum
> workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
> The following patch fixes it

It's been discussed over the last few days, and the conclusion that has
been reached is that the work-around is in fact itself buggy.  The real
fix should be merged soon.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Re: pxamci.c fails to compile

[Pierre Ossman]

Russell King wrote:
> On Mon, May 14, 2007 at 11:22:04AM +0300, Mike Rapoport wrote:
>> The PXA MMC controller does not compile for PXA27x after MMC
>> reorganization, because it uses protocol defines to implement HW erratum
>> workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
>> The following patch fixes it
> 
> It's been discussed over the last few days, and the conclusion that has
> been reached is that the work-around is in fact itself buggy.  The real
> fix should be merged soon.
> 

Indeed. I have the fix ready to go. I was hoping I could get some fix for at91
aswell, but that doesn't seem to be happening so I'll push in a bit.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org