* [PATCH ext3/ext4] lost brelse in ext3_read_inode
@ 2007-06-02 12:40 Vasily Averin
0 siblings, 0 replies; only message in thread
From: Vasily Averin @ 2007-06-02 12:40 UTC (permalink / raw)
To: Linux Kernel Mailing List, Andrew Morton, devel, linux-ext4,
Stephen Tweedie, adilger
From: Kirill Korotaev <dev@openvz.org>
One of error path in ext3_read_inode() leaks bh since brelse is forgoten.
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
Acked-by: Vasily Averin <vvs@sw.ru>
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index a6cb617..2a85dde 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -2677,8 +2677,10 @@ void ext3_read_inode(struct inode * inode)
*/
ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
if (EXT3_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
- EXT3_INODE_SIZE(inode->i_sb))
+ EXT3_INODE_SIZE(inode->i_sb)) {
+ brelse (bh);
goto bad_inode;
+ }
if (ei->i_extra_isize == 0) {
/* The extra space is currently unused. Use it. */
ei->i_extra_isize = sizeof(struct ext3_inode) -
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index b34182b..0cd7bc4 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2673,8 +2673,10 @@ void ext4_read_inode(struct inode * inode)
*/
ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
- EXT4_INODE_SIZE(inode->i_sb))
+ EXT4_INODE_SIZE(inode->i_sb)) {
+ brelse (bh);
goto bad_inode;
+ }
if (ei->i_extra_isize == 0) {
/* The extra space is currently unused. Use it. */
ei->i_extra_isize = sizeof(struct ext4_inode) -
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-06-02 12:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-02 12:40 [PATCH ext3/ext4] lost brelse in ext3_read_inode Vasily Averin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox