From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andres Salomon <dilinger@queued.net>,
linux-kernel@vger.kernel.org,
Jordan Crouse <jordan.crouse@amd.com>
Subject: Re: [PATCH 1/3] GEODE: basic infrastructure support for AMD geode-class machines
Date: Fri, 06 Jul 2007 14:55:21 +0100 [thread overview]
Message-ID: <468E49C9.3000200@shadowen.org> (raw)
In-Reply-To: <20070705152616.31c7c0d1.akpm@linux-foundation.org>
Andrew Morton wrote:
> The patches have some trivial-but-common coding-style bloopers which
> scripts/checkpatch.pl will detect. Please check it out.
> oh
> Please send a patch which documents mfgpt_irq in
> Documentation/kernel-parameters.txt, thanks.
>
> Andy, the miss rate on documentation for new __setup() handlers is about
> 75%. Might be worth adding to checkpatch.pl.
If we are willing to expect the update in the same patch then we can
emit a failure if the presented string in __check isn't in the update to
the documentation. I guess emit it as a CHECK in case they have loads
of them and a separate documentation patch.
CHECK: __setup appears un-documented -- check
Documentation/kernel-parameters.txt
#131: FILE: arch/i386/kernel/mfgpt.c:233:
+__setup("mfgpt_irq=", mfgpt_setup);
-apw
prev parent reply other threads:[~2007-07-06 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 20:02 [PATCH 1/3] GEODE: basic infrastructure support for AMD geode-class machines Andres Salomon
2007-07-05 22:26 ` Andrew Morton
2007-07-06 13:55 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468E49C9.3000200@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox