* [linux-2.6.git] IDE/ATA fighting over driver name?
@ 2007-10-13 5:41 Mike Galbraith
2007-10-13 10:51 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Mike Galbraith @ 2007-10-13 5:41 UTC (permalink / raw)
To: Linux-Kernel Mailinglist
Greetings,
Perhaps my .config is dainbramaged. When make oldconfig asked me if I
wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it".
drivers/ide/legacy/ide_platform.c: .name = "pata_platform",
drivers/ata/pata_platform.c:#define DRV_NAME "pata_platform"
[ 26.586663] sysfs: duplicate filename 'pata_platform' can not be created
[ 26.601006] WARNING: at fs/sysfs/dir.c:425 sysfs_add_one()
[ 26.614080] [<c010515a>] show_trace_log_lvl+0x1a/0x30
[ 26.626777] [<c0105d33>] show_trace+0x12/0x14
[ 26.638668] [<c0105d4b>] dump_stack+0x16/0x18
[ 26.650306] [<c01b905d>] sysfs_add_one+0x91/0xc6
[ 26.662311] [<c01b954d>] create_dir+0x43/0x7a
[ 26.673884] [<c01b95af>] sysfs_create_dir+0x2b/0x43
[ 26.685944] [<c02c8dfa>] kobject_add+0x97/0x1b5
[ 26.697775] [<c02c8f83>] kobject_register+0x1c/0x37
[ 26.709873] [<c034d089>] bus_add_driver+0x62/0x1cf
[ 26.721833] [<c034dbe9>] driver_register+0x42/0x6c
[ 26.733682] [<c034ecbc>] platform_driver_register+0x66/0x68
[ 26.746301] [<c065f889>] pata_platform_init+0xd/0xf
[ 26.758138] [<c0645556>] kernel_init+0x131/0x2fb
[ 26.769631] [<c0104db3>] kernel_thread_helper+0x7/0x14
[ 26.781659] =======================
[ 26.791959] kobject_add failed for pata_platform with -EEXIST, don't try to register things with the same name in the same directory.
[ 26.818148] [<c010515a>] show_trace_log_lvl+0x1a/0x30
[ 26.830479] [<c0105d33>] show_trace+0x12/0x14
[ 26.842032] [<c0105d4b>] dump_stack+0x16/0x18
[ 26.853507] [<c02c8e7f>] kobject_add+0x11c/0x1b5
[ 26.865070] [<c02c8f83>] kobject_register+0x1c/0x37
[ 26.876702] [<c034d089>] bus_add_driver+0x62/0x1cf
[ 26.888250] [<c034dbe9>] driver_register+0x42/0x6c
[ 26.899788] [<c034ecbc>] platform_driver_register+0x66/0x68
[ 26.912009] [<c065f889>] pata_platform_init+0xd/0xf
[ 26.923379] [<c0645556>] kernel_init+0x131/0x2fb
[ 26.934490] [<c0104db3>] kernel_thread_helper+0x7/0x14
[ 26.946010] =======================
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-2.6.git] IDE/ATA fighting over driver name?
2007-10-13 5:41 [linux-2.6.git] IDE/ATA fighting over driver name? Mike Galbraith
@ 2007-10-13 10:51 ` Jeff Garzik
2007-10-13 12:02 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-10-13 10:51 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Linux-Kernel Mailinglist, IDE/ATA development list
Mike Galbraith wrote:
> Greetings,
>
> Perhaps my .config is dainbramaged. When make oldconfig asked me if I
> wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it".
>
> drivers/ide/legacy/ide_platform.c: .name = "pata_platform",
> drivers/ata/pata_platform.c:#define DRV_NAME "pata_platform"
That's a clear bug.. IDE's should be called ide_platform.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-2.6.git] IDE/ATA fighting over driver name?
2007-10-13 10:51 ` Jeff Garzik
@ 2007-10-13 12:02 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-10-13 12:02 UTC (permalink / raw)
To: Jeff Garzik
Cc: Mike Galbraith, Linux-Kernel Mailinglist,
IDE/ATA development list
On Sat, 13 Oct 2007 06:51:06 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> Mike Galbraith wrote:
> > Greetings,
> >
> > Perhaps my .config is dainbramaged. When make oldconfig asked me if I
> > wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it".
> >
> > drivers/ide/legacy/ide_platform.c: .name = "pata_platform",
> > drivers/ata/pata_platform.c:#define DRV_NAME "pata_platform"
>
> That's a clear bug.. IDE's should be called ide_platform.
No its intentional and was discussed. Both of them provide an identical
platform driver interface, so they both use the same name. This means an
embedded platform developer doesn't have to choose which driver each of
their downstream users gets.
Probably just needs a bit of ifdef twiddling, if its even a bug (which is
not clear).
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-13 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-13 5:41 [linux-2.6.git] IDE/ATA fighting over driver name? Mike Galbraith
2007-10-13 10:51 ` Jeff Garzik
2007-10-13 12:02 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox