[PATCH 0/2] Fix LoongArch dtbs_check warnings

[PATCH 0/2] Fix LoongArch dtbs_check warnings

[Yao Zi]

Running dtbs_check with ARCH=loongarch emits a lot of warnings, most
about describing sideband interrupts for PCI devices through interrupts
property, and usage of undocumented msi-parent property in pcie
controller in loongson-2k2000.dtsi.

Patch 1 solves the former problem by using interrupts-extended property
for these devices. I don't have LS2K1000/2000 devices on hand, so
helping in testing it will be appreciated. msi-parent property is
documented in the second patch for Loongson PCI controllers.

After applying the series, the only two warnings left are about naming
of I2C controllers,

/builder/repo/linux/arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
/builder/repo/linux/arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: i2c-gpio-1 (i2c-gpio): $nodename:0: 'i2c-gpio-1' does not match '^i2c(@.+|-[a-z0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#

which IMHO is a regression caused by dt-schema commit 57138f5b8c92
("schemas: i2c: Avoid extra characters in i2c nodename pattern"). Commit
647181a1f8ff ("schemas: i2c: Allow for 'i2c-.*' node names") fails to
fix the case, as it doesn't take nodenames with multiple hyphens in
account. I'll start a separate series for this.

Thanks for your time and review.

Yao Zi (2):
  LoongArch: dts: Describe PCI sideband IRQ through interrupt-extended
  dt-bindings: PCI: loongson: Document msi-parent property

 .../devicetree/bindings/pci/loongson.yaml     |  2 ++
 arch/loongarch/boot/dts/loongson-2k1000.dtsi  | 25 ++++++---------
 arch/loongarch/boot/dts/loongson-2k2000.dtsi  | 32 +++++++------------
 3 files changed, 23 insertions(+), 36 deletions(-)

-- 
2.51.2

[PATCH 1/2] LoongArch: dts: Describe PCI sideband IRQ through interrupt-extended

[Yao Zi]

SoC integrated peripherals on LS2K1000 and LS2K2000 could be discovered
as PCI devices, but require sideband interrupts to function, which are
previously described by interrupts and interrupt-parent properties.

However, pci/pci-device.yaml allows interrupts property to only specify
PCI INTx interrupts, not sideband ones. Convert these devices to use
interrupt-extended property, which describes sideband interrupts used by
PCI devices since dt-schema commit e6ea659d2baa ("schemas: pci-device:
Allow interrupts-extended for sideband interrupts"), eliminating
dtbs_check warnings.

Fixes: 30a5532a3206 ("LoongArch: dts: DeviceTree for Loongson-2K1000")
Signed-off-by: Yao Zi <me@ziyao.cc>
---
 arch/loongarch/boot/dts/loongson-2k1000.dtsi | 25 ++++++---------
 arch/loongarch/boot/dts/loongson-2k2000.dtsi | 32 ++++++++------------
 2 files changed, 21 insertions(+), 36 deletions(-)

diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
index 60ab425f793f..eee06b84951c 100644
--- a/arch/loongarch/boot/dts/loongson-2k1000.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
@@ -437,54 +437,47 @@ pcie@1a000000 {
 
 			gmac0: ethernet@3,0 {
 				reg = <0x1800 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc0>;
-				interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,
-					     <13 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc0 12 IRQ_TYPE_LEVEL_HIGH>,
+						      <&liointc0 13 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "macirq", "eth_lpi";
 				status = "disabled";
 			};
 
 			gmac1: ethernet@3,1 {
 				reg = <0x1900 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc0>;
-				interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,
-					     <15 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc0 14 IRQ_TYPE_LEVEL_HIGH>,
+						      <&liointc0 15 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "macirq", "eth_lpi";
 				status = "disabled";
 			};
 
 			ehci0: usb@4,1 {
 				reg = <0x2100 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc1>;
-				interrupts = <18 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc1 18 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			ohci0: usb@4,2 {
 				reg = <0x2200 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc1>;
-				interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc1 19 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			display@6,0 {
 				reg = <0x3000 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc0>;
-				interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc0 28 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			hda@7,0 {
 				reg = <0x3800 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc0>;
-				interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc0 4 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			sata: sata@8,0 {
 				reg = <0x4000 0x0 0x0 0x0 0x0>;
-				interrupt-parent = <&liointc0>;
-				interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&liointc0 19 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
diff --git a/arch/loongarch/boot/dts/loongson-2k2000.dtsi b/arch/loongarch/boot/dts/loongson-2k2000.dtsi
index 6c77b86ee06c..87c45f1f7cc7 100644
--- a/arch/loongarch/boot/dts/loongson-2k2000.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k2000.dtsi
@@ -291,65 +291,57 @@ pcie@1a000000 {
 
 			gmac0: ethernet@3,0 {
 				reg = <0x1800 0x0 0x0 0x0 0x0>;
-				interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,
-					     <13 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&pic 12 IRQ_TYPE_LEVEL_HIGH>,
+						      <&pic 13 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "macirq", "eth_lpi";
-				interrupt-parent = <&pic>;
 				status = "disabled";
 			};
 
 			gmac1: ethernet@3,1 {
 				reg = <0x1900 0x0 0x0 0x0 0x0>;
-				interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,
-					     <15 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&pic 14 IRQ_TYPE_LEVEL_HIGH>,
+						      <&pic 15 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "macirq", "eth_lpi";
-				interrupt-parent = <&pic>;
 				status = "disabled";
 			};
 
 			gmac2: ethernet@3,2 {
 				reg = <0x1a00 0x0 0x0 0x0 0x0>;
-				interrupts = <17 IRQ_TYPE_LEVEL_HIGH>,
-					     <18 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&pic 17 IRQ_TYPE_LEVEL_HIGH>,
+						      <&pic 18 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "macirq", "eth_lpi";
-				interrupt-parent = <&pic>;
 				status = "disabled";
 			};
 
 			xhci0: usb@4,0 {
 				reg = <0x2000 0x0 0x0 0x0 0x0>;
-				interrupts = <48 IRQ_TYPE_LEVEL_HIGH>;
-				interrupt-parent = <&pic>;
+				interrupts-extended = <&pic 48 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			xhci1: usb@19,0 {
 				reg = <0xc800 0x0 0x0 0x0 0x0>;
-				interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
-				interrupt-parent = <&pic>;
+				interrupts-extended = <&pic 22 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			display@6,1 {
 				reg = <0x3100 0x0 0x0 0x0 0x0>;
-				interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
-				interrupt-parent = <&pic>;
+				interrupts-extended = <&pic 28 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			i2s@7,0 {
 				reg = <0x3800 0x0 0x0 0x0 0x0>;
-				interrupts = <78 IRQ_TYPE_LEVEL_HIGH>,
-					     <79 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts-extended = <&pic 78 IRQ_TYPE_LEVEL_HIGH>,
+						      <&pic 79 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-names = "tx", "rx";
-				interrupt-parent = <&pic>;
 				status = "disabled";
 			};
 
 			sata: sata@8,0 {
 				reg = <0x4000 0x0 0x0 0x0 0x0>;
-				interrupts = <16 IRQ_TYPE_LEVEL_HIGH>;
-				interrupt-parent = <&pic>;
+				interrupts-extended = <&pic 16 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
-- 
2.51.2

[PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property

[Yao Zi]

Loongson PCI controllers found in LS2K1000/2000 SoCs
(loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
controllers.

Though only the one in LS2K2000 SoC is described in devicetree, we
should document the property for all variants. For the same reason, it
isn't marked as required for now.

Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
Signed-off-by: Yao Zi <me@ziyao.cc>
---
 Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml
index e5bba63aa947..26e77218b901 100644
--- a/Documentation/devicetree/bindings/pci/loongson.yaml
+++ b/Documentation/devicetree/bindings/pci/loongson.yaml
@@ -32,6 +32,8 @@ properties:
     minItems: 1
     maxItems: 3
 
+  msi-parent: true
+
 required:
   - compatible
   - reg
-- 
2.51.2

Re: [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property

[Rob Herring (Arm)]

On Tue, 09 Dec 2025 14:00:06 +0000, Yao Zi wrote:
> Loongson PCI controllers found in LS2K1000/2000 SoCs
> (loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
> RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
> controllers.
> 
> Though only the one in LS2K2000 SoC is described in devicetree, we
> should document the property for all variants. For the same reason, it
> isn't marked as required for now.
> 
> Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
> Signed-off-by: Yao Zi <me@ziyao.cc>
> ---
>  Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property

[Krzysztof Kozlowski]

On 09/12/2025 23:39, Rob Herring (Arm) wrote:
> 
> On Tue, 09 Dec 2025 14:00:06 +0000, Yao Zi wrote:
>> Loongson PCI controllers found in LS2K1000/2000 SoCs
>> (loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
>> RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
>> controllers.
>>
>> Though only the one in LS2K2000 SoC is described in devicetree, we
>> should document the property for all variants. For the same reason, it
>> isn't marked as required for now.
>>
>> Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
>> Signed-off-by: Yao Zi <me@ziyao.cc>
>> ---
>>  Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> 

Seems my explicit pointing towards Loongarch during OSS talk brought
some effects...

Best regards,
Krzysztof

Re: (subset) [PATCH 0/2] Fix LoongArch dtbs_check warnings

[Manivannan Sadhasivam]

On Tue, 09 Dec 2025 14:00:04 +0000, Yao Zi wrote:
> Running dtbs_check with ARCH=loongarch emits a lot of warnings, most
> about describing sideband interrupts for PCI devices through interrupts
> property, and usage of undocumented msi-parent property in pcie
> controller in loongson-2k2000.dtsi.
> 
> Patch 1 solves the former problem by using interrupts-extended property
> for these devices. I don't have LS2K1000/2000 devices on hand, so
> helping in testing it will be appreciated. msi-parent property is
> documented in the second patch for Loongson PCI controllers.
> 
> [...]

Applied, thanks!

[2/2] dt-bindings: PCI: loongson: Document msi-parent property
      commit: d782e6e7aa798a2c28f30f984ea6dcdb63f51674

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>