[PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[David Miller]

Now that we have dealt with the real issue, in that some ATI SATA and
USB controllers needed the INTX_DISABLE quirk, we can remove these AMD
chipset global MSI disabling quirks.

This reverts three changesets:

4be8f906435a6af241821ab5b94b2b12cb7d57d8 (PCI: disable MSI on RS690)
aea6a433f50cd89b9cbd10850fd0b32f961f9883 (PCI: disable MSI on RD580)
f122392f679ebed39db08074f935d770504623eb (PCI: disable MSI on RX790)

This is based upon testing and feedback from
Shane Huang <Shane.Huang@amd.com>.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/pci/quirks.c    |    3 ---
 include/linux/pci_ids.h |    3 ---
 2 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index d8f2d89..26cc4dc 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1623,9 +1623,6 @@ static void __init quirk_disable_all_msi(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disable_all_msi);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RD580, quirk_disable_all_msi);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RX790, quirk_disable_all_msi);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS690, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351, quirk_disable_all_msi);
 
 /* Disable MSI on chipsets that are known to not support it */
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index c64bb89..e66af5d 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -360,9 +360,6 @@
 #define PCI_DEVICE_ID_ATI_RS400_166     0x5a32
 #define PCI_DEVICE_ID_ATI_RS400_200     0x5a33
 #define PCI_DEVICE_ID_ATI_RS480         0x5950
-#define PCI_DEVICE_ID_ATI_RD580		0x5952
-#define PCI_DEVICE_ID_ATI_RX790		0x5957
-#define PCI_DEVICE_ID_ATI_RS690		0x7910
 /* ATI IXP Chipset */
 #define PCI_DEVICE_ID_ATI_IXP200_IDE	0x4349
 #define PCI_DEVICE_ID_ATI_IXP200_SMBUS	0x4353
-- 
1.5.2.5

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[David Gaarenstroom]

2007/10/25, David Miller <davem@davemloft.net>:
>
> Now that we have dealt with the real issue, in that some ATI SATA and
> USB controllers needed the INTX_DISABLE quirk, we can remove these AMD
> chipset global MSI disabling quirks.

IMHO we should remove *all* former ATI "AMD" chipset global MSI
disabling quirks... The whole idea was to sort things out once and for
all. At least the RS480 quirk can be removed, now that the USB driver
has the workaround for the SB400 southbridge USB. I suspect the same
counts for the other ATI chipsets...

To quote Greg K-H:
"But for now, let's not take a band-aid that prevents others from
working to solve the real issues here."

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[David Miller]

From: "David Gaarenstroom" <david.gaarenstroom@gmail.com>
Date: Fri, 26 Oct 2007 12:56:52 +0200

> 2007/10/25, David Miller <davem@davemloft.net>:
> >
> > Now that we have dealt with the real issue, in that some ATI SATA and
> > USB controllers needed the INTX_DISABLE quirk, we can remove these AMD
> > chipset global MSI disabling quirks.
> 
> IMHO we should remove *all* former ATI "AMD" chipset global MSI
> disabling quirks... The whole idea was to sort things out once and for
> all. At least the RS480 quirk can be removed, now that the USB driver
> has the workaround for the SB400 southbridge USB. I suspect the same
> counts for the other ATI chipsets...

I would like those to be removed, but to be conservative we should
first get some testing feedback that confirms this just like those
provided to me from the AMD folks for the RS690, RX790 and RD580
cases.

Otherwise the risk to break people's systems is very real.

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[David Gaarenstroom]

> I would like those to be removed, but to be conservative we should
> first get some testing feedback that confirms this just like those
> provided to me from the AMD folks for the RS690, RX790 and RD580
> cases.

The patch works fine for my laptop with the RS480 chipset (with a
SB400 southbridge).
But it would be nice if AMD tested it as well...

BTW, here you can see that the SB400 USB controller was the only real
problem for the RS480 chipset in the first place:
http://lkml.org/lkml/2006/12/21/47

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[David Miller]

From: "David Gaarenstroom" <david.gaarenstroom@gmail.com>
Date: Sun, 28 Oct 2007 21:11:13 +0100

> > I would like those to be removed, but to be conservative we should
> > first get some testing feedback that confirms this just like those
> > provided to me from the AMD folks for the RS690, RX790 and RD580
> > cases.
> 
> The patch works fine for my laptop with the RS480 chipset (with a
> SB400 southbridge).
> But it would be nice if AMD tested it as well...

So please submit "The patch" :-)

RE: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[Shane Huang]

> I would like those to be removed, but to be conservative we should
> first get some testing feedback that confirms this just like those
> provided to me from the AMD folks for the RS690, RX790 and RD580
> cases.
> 
> Otherwise the risk to break people's systems is very real.

In fact, our team only has boards with RS690+SB700 and RX790+SB700,
I don't know why the RD580 MSI is disabled too by the patch
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
t;h=aea6a433f50cd89b9cbd10850fd0b32f961f9883
Maybe Tejun can give us more information on this case,
I think the cause should be same as RS690 and RX790.

If you need some small test on USB issue related with RS480 or
something else, you may tell me, I can try to ask the help from our
SW QA or test by myself, if we can find out such test platform.

Thanks
Shane

Re: [PATCH 5/5]: [PCI]: Remove 3 incorrect MSI quirks.

[Tejun Heo]

Shane Huang wrote:
>> I would like those to be removed, but to be conservative we should
>> first get some testing feedback that confirms this just like those
>> provided to me from the AMD folks for the RS690, RX790 and RD580
>> cases.
>>
>> Otherwise the risk to break people's systems is very real.
> 
> In fact, our team only has boards with RS690+SB700 and RX790+SB700,
> I don't know why the RD580 MSI is disabled too by the patch
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=aea6a433f50cd89b9cbd10850fd0b32f961f9883
> Maybe Tejun can give us more information on this case,
> I think the cause should be same as RS690 and RX790.

I don't remember history of each quirk entry but they're either reported
in a bug report and successfully worked around with pci=nomsi or one of
AMD guys told me certain PCI IDs share the same problem.  I can dig mail
archive if you wanna know how it went down for RD580.

-- 
tejun