* [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend
@ 2022-05-30 7:51 Weizhao Ouyang
2022-05-30 8:08 ` Gao Xiang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Weizhao Ouyang @ 2022-05-30 7:51 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, Yue Hu; +Cc: linux-erofs, linux-kernel, Weizhao Ouyang
Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
---
fs/erofs/zdata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 95efc127b2ba..94d2cb970644 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
#define DECOMPRESS_FRONTEND_INIT(__i) { \
.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
- .mode = COLLECT_PRIMARY_FOLLOWED }
+ .mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
static DEFINE_MUTEX(z_pagemap_global_lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend
2022-05-30 7:51 [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend Weizhao Ouyang
@ 2022-05-30 8:08 ` Gao Xiang
2022-05-30 8:48 ` Yue Hu
2022-05-31 2:27 ` Chao Yu
2 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2022-05-30 8:08 UTC (permalink / raw)
To: Weizhao Ouyang; +Cc: Gao Xiang, Chao Yu, Yue Hu, linux-erofs, linux-kernel
On Mon, May 30, 2022 at 03:51:14PM +0800, Weizhao Ouyang wrote:
> Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
>
> Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
> Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
Many thanks for the in-time catching! ;)
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
> ---
> fs/erofs/zdata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 95efc127b2ba..94d2cb970644 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
>
> #define DECOMPRESS_FRONTEND_INIT(__i) { \
> .inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
> - .mode = COLLECT_PRIMARY_FOLLOWED }
> + .mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
>
> static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
> static DEFINE_MUTEX(z_pagemap_global_lock);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend
2022-05-30 7:51 [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend Weizhao Ouyang
2022-05-30 8:08 ` Gao Xiang
@ 2022-05-30 8:48 ` Yue Hu
2022-05-31 2:27 ` Chao Yu
2 siblings, 0 replies; 4+ messages in thread
From: Yue Hu @ 2022-05-30 8:48 UTC (permalink / raw)
To: Weizhao Ouyang; +Cc: Gao Xiang, Chao Yu, Yue Hu, linux-erofs, linux-kernel
On Mon, 30 May 2022 15:51:14 +0800
Weizhao Ouyang <o451686892@gmail.com> wrote:
> Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
>
> Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
> Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
Good catch.
Reviewed-by: Yue Hu <huyue2@coolpad.com>
> ---
> fs/erofs/zdata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 95efc127b2ba..94d2cb970644 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
>
> #define DECOMPRESS_FRONTEND_INIT(__i) { \
> .inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
> - .mode = COLLECT_PRIMARY_FOLLOWED }
> + .mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
>
> static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
> static DEFINE_MUTEX(z_pagemap_global_lock);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend
2022-05-30 7:51 [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend Weizhao Ouyang
2022-05-30 8:08 ` Gao Xiang
2022-05-30 8:48 ` Yue Hu
@ 2022-05-31 2:27 ` Chao Yu
2 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2022-05-31 2:27 UTC (permalink / raw)
To: Weizhao Ouyang, Gao Xiang, Yue Hu; +Cc: linux-erofs, linux-kernel
On 2022/5/30 15:51, Weizhao Ouyang wrote:
> Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
>
> Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
> Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-31 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-30 7:51 [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend Weizhao Ouyang
2022-05-30 8:08 ` Gao Xiang
2022-05-30 8:48 ` Yue Hu
2022-05-31 2:27 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox